Learn icon indicating copy to clipboard operation
Learn copied to clipboard

WP Training Team GitHub repository updates

Open jonathanbossenger opened this issue 1 month ago • 16 comments

We have a https://github.com/wptrainingteam GitHub organisation.

Historically this was where the training team originally hosted all it's content, until learn.wordpress.org became the official online home.

Many of the repositories in this organisation use package dependancies (npm, composer) which can become out of date over time.

The plan is to get each of these repositories checked, and updated as required.

jonathanbossenger avatar Nov 11 '25 09:11 jonathanbossenger

I have created documentation for the steps required to check each repository and update it if needed

https://docs.google.com/document/d/19mVMn5_UmnsDERkNJAYo8EVYbX9XdhAiZKVxZatEppk/edit?usp=sharing

Please review the documentation and let me know if anything is unclear.

jonathanbossenger avatar Nov 11 '25 09:11 jonathanbossenger

Once we're happy with the documentation steps, I can create a project post on the Training Team site.

jonathanbossenger avatar Nov 11 '25 09:11 jonathanbossenger

I'm also interested in helping out @jonathanbossenger !

thatmitchcanter avatar Nov 12 '25 15:11 thatmitchcanter

I read the documentation - it is clear and concise. We can start whenever you are ready, @jonathanbossenger.

rjekic avatar Nov 13 '25 09:11 rjekic

Thanks @rjekic. I think it will be worthwhile to leave it open for review for another week, maybe even mention it in the next training team meeting, so we make sure enough folks can share their feedback.

jonathanbossenger avatar Nov 14 '25 06:11 jonathanbossenger

@jonathanbossenger Thank you so much for the detailed instructions. I worked through them with my first PR for example code for the Dev Blog. I found them to be comprehensive enough for my level of knowledge (=low). Fabulous work!

bph avatar Nov 18 '25 08:11 bph

Thanks, everyone. I have created a handbook page which includes the instructions, and I am in the process of writing a post for the training team site.

How do we want contributors to let us know when a PR is ready for review? My initial thought is to get them to request a review from a curated set of folks who can review and merge the PR.

So far, I am happy to be on that list, and I think this would also be a great one for @thatmitchcanter to help with, as it will just be reviewing and merging a PR.

Please let me know in the comments here by Friday if you would also like to be included in this list.

jonathanbossenger avatar Nov 20 '25 08:11 jonathanbossenger

You can add me to the list, if that helps.

bph avatar Nov 20 '25 13:11 bph

On this PR

I also ran into this issue: that the auto-merge won't work.

Image

bph avatar Nov 20 '25 14:11 bph

On this PR

I also ran into this issue: that the auto-merge won't work.

Thanks for sharing @bph. I don't remember setting this, but it does appear that this all requires a branch protection ruleset set up for each repository. (Example here for the plugin-developer repository: https://github.com/wptrainingteam/plugin-developer/settings/rules/9320095

Fortunately, we can import this per repository from this Branch Protection Rules.json file. So we can ask the PR reviewers to check if Branch protection rules are set up on the repo, and if not, import the file and save the ruleset.

I'll create instructions for the PR reviewers for this as well.

I just created Branch Protection Rules for the post-review-blocks repository, so future attempts at auto-merge should work. I also approved and merged those PRs.

jonathanbossenger avatar Nov 20 '25 14:11 jonathanbossenger

@bph @rjekic @devmuhib009 @sumitsinghwp @thatmitchcanter I've created a new tab in the shared Google Doc with "PR review instructions". This includes details for the folks who will be doing the PR Reviews, as well as instructions on setting up branch protection rules (if required) from the JSON file. Please review the new docs and let me know if anything is unclear.

jonathanbossenger avatar Nov 21 '25 06:11 jonathanbossenger

Thank you so much @jonathanbossenger . I will review then let you know 😀

sumitsinghwp avatar Nov 21 '25 19:11 sumitsinghwp

@jonathanbossenger this all looks very clear and makes complete sense. Please include me in anything that you need, and I'll get this set up and ready to go soon on my end.

thatmitchcanter avatar Nov 24 '25 15:11 thatmitchcanter

@jonathanbossenger

The same goes for me - ready when you are!

rjekic avatar Nov 26 '25 12:11 rjekic

Thanks everyone for your input.

  1. I have updated the handbook to include the page for reviewers (yourselves) with instructions on setting up the branch protection rules.
  2. I have invited everyone to the https://github.com/wptrainingteam organisation as "Owners" (with great power and all that).
  3. I have published a post on the Training Team site inviting folks to help https://make.wordpress.org/training/2025/11/28/help-secure-the-learn-wordpress-code-examples/. If we can please mention the post in future training team meetings.

I am going to close this issue, but feel free to reopen it if there are any questions or future updates to this project.

jonathanbossenger avatar Nov 28 '25 06:11 jonathanbossenger

Reopening this issue to restructure the handbook pages slightly to support adding a check list for code owners, so we don't have this issue going forward.

jonathanbossenger avatar Dec 04 '25 12:12 jonathanbossenger

Handbook pages have been updated, so closing this for now.

jonathanbossenger avatar Dec 22 '25 10:12 jonathanbossenger