Learn icon indicating copy to clipboard operation
Learn copied to clipboard

Adds a bordered-image utility class

Open jonathanbossenger opened this issue 3 years ago • 3 comments

Fixes #1025

In some cases, screenshots may contain a lot of the color white.

This might cause the image to blend in with the white background, and may therefore not be as impactful for the content.

This class can be applied to a specific image block to add a slight border around the image

jonathanbossenger avatar Oct 17 '22 12:10 jonathanbossenger

This is a great idea! Definitely happy to merge this, although I see there's a linting error there that I don't understand. @adamwoodnz could you have a look at that?

hlashbrooke avatar Oct 19 '22 19:10 hlashbrooke

Something happened with building an unrelated package in the repo so I've added a commit to fix this. Probably worth a smoke test of the locale switcher before merging this.

adamwoodnz avatar Oct 20 '22 02:10 adamwoodnz

Something happened with building an unrelated package in the repo so I've added a commit to fix this.

Aha, that explains the errors I was getting when trying to test locally, it works now, thanks @adamwoodnz

I've tested the fix locally, and it works on the image block perfectly.

Adding-a-Contact-Form-to-Your-Site-learn-wordpress

Probably worth a smoke test of the locale switcher before merging this.

I'm not sure how to test the local switcher. Is that a separate piece of functionality, or a different PR you're referring to?

jonathanbossenger avatar Oct 20 '22 06:10 jonathanbossenger

@adamwoodnz is there any way this could be merged during the course of this week? The main reason I ask is that I'd like to use it for my block theme course, which we're aiming to publish next Monday.

jonathanbossenger avatar Oct 24 '22 08:10 jonathanbossenger