Learn icon indicating copy to clipboard operation
Learn copied to clipboard

Bug report - layout bug when editing Sensei course lessons

Open jonathanbossenger opened this issue 3 years ago • 3 comments

Description

When editing a lesson in Sensei, there seems to be something causing the layout to break. I'm not sure if this is a Sensei issue, or a Learn WordPress issue.

Step-by-step reproduction instructions

  1. Edit a course
  2. Edit a lesson in a course
  3. View the layout for the lesson

Expected behaviour

I would expect the editor to display with the same "margins" as other content being edited

Actual behaviour

It does not have any of the spacing of other content being edited, and there appears to be a weird padding or layout element applied on the left of the menu

When I test this on a clean WordPress install with Sensei installed, this does not happen, so it looks like it's a Learn specific customisation that's caused this.

Screenshots or screen recording (optional)

https://user-images.githubusercontent.com/180629/195289104-a38a4198-6fcc-4c8b-b13a-8d3cc6aa22a7.mp4

Environment information

  • Brave
  • M1 MacBook Pro, with Monterey

jonathanbossenger avatar Oct 12 '22 08:10 jonathanbossenger

Additional screenshots

What I would expect (Editing a tutorial)

Edit-Tutorial-“Advanced-Layouts-with-the-Block-Editor”-‹-Learn-WordPress-—-WordPress

What I see editing a lesson

Edit-Lesson-“Creating-Custom-Templates-and-Template-Parts”-‹-Learn-WordPress-—-WordPress

jonathanbossenger avatar Oct 12 '22 11:10 jonathanbossenger

I can confirm that there is a padding issue while editing lessons.

Edit_Lesson_“What_Happens_When_Creating_and_Saving_Templates_Templates_Parts”_‹Learn_WordPress—_WordPress

digitalchild avatar Oct 12 '22 11:10 digitalchild

I can confirm that this doesn't happen on my current local version of the Learn code, which I last updated on 20 September (and is up to this commit) so something in the last month has caused this.

I'm going to try and incrementally pull by commit to my local to see if I can isolate where the change happened.

jonathanbossenger avatar Oct 13 '22 16:10 jonathanbossenger