HelpHub icon indicating copy to clipboard operation
HelpHub copied to clipboard

Update theme name in Gruntfile.js

Open felipeelia opened this issue 7 years ago • 2 comments

This PR changes the theme name in Gruntfile.js, otherwise theme files won't be affected by grunt sass or grunt watch commands.

Seems to be related to #154.

felipeelia avatar May 22 '18 12:05 felipeelia

It looks like you might have an old version of the directory, I'd recommend doing a pull first.

Also, theme-related stuff is already covered by the gruntfile in the theme directory, we should remove it from the root-gruntfile to avoid unexpected collisions or surprises.

Clorith avatar May 22 '18 13:05 Clorith

Sorry @Clorith. The file isn't that way here? I did a pull first...

And to use theme's Gruntfile we should update it's grunt-sass version, like was done in #197. The actual version didn't work for me (maybe it's too old?).

Sorry if am I not seeing something obvious here.

felipeelia avatar May 22 '18 13:05 felipeelia