Documentation-Issue-Tracker icon indicating copy to clipboard operation
Documentation-Issue-Tracker copied to clipboard

[HelpHub] Content review: Video shortcode

Open estelaris opened this issue 2 years ago • 12 comments

Issue Description

Still contains links to Codex

URL of the Page with the Issue

Video shortcode

Section of Page with the issue

Related

Why is this a problem?

Are links still valid? Are there plans to bring the other shortcode articles into DevHub?

Suggested Fix

If needed, transfer the other shortcode articles into DevHub and move this article to DevHub as marked in #388

estelaris avatar Sep 26 '22 20:09 estelaris

Heads up @lucprincen @javiercasares - the "advanced administration" label was applied to this issue.

github-actions[bot] avatar Sep 26 '22 20:09 github-actions[bot]

Heads up @femkreations @atachibana - the "user documentation" label was applied to this issue.

github-actions[bot] avatar Sep 28 '22 09:09 github-actions[bot]

I found other shortcode articles and these can be used in the code block so they can remain in en-user documentation.

estelaris avatar Sep 28 '22 09:09 estelaris

Hi! I'll try to tackle this one as my first issue 🙌

carmoreira avatar Apr 14 '23 13:04 carmoreira

I will check this.

marconmartins avatar Jun 08 '23 07:06 marconmartins

Revised the codex links of the Video Shortcode page and below are the revised versions of the linked shortcode pages.

Caption Shortcode Updated the shortcode parameters, a couple were missing. https://docs.google.com/document/d/1ELKXlJ3-72N7HQstClApw3gFivu60SuutRTVIi7alJE/edit?usp=sharing

Embed Shortcode Updated some links from codex to the new documentation. https://docs.google.com/document/d/1812oZyG7BAabYxXldk4oGyeKeQNwP6iWPar5jWr9nm4/edit?usp=sharing

Gallery Shortcode Updated some links from codex that have a new version and updated the options section with the ids arguments. https://docs.google.com/document/d/1I7DmNA8BnUQM2AViP0SYmjkTA0S5fbnpPQiVyQ7SJrE/edit?usp=sharing

Playlist Shortcode Updated some links from codex that have a new version. https://docs.google.com/document/d/12KYTDMxEvQpQXEpwNkXehh4_vXvSLP7DoeNtUivn2gk/edit?usp=sharing

marconmartins avatar Jun 08 '23 12:06 marconmartins

I'll review this as discussed in Slack :)

pekkakortelainen avatar Jun 13 '23 14:06 pekkakortelainen

One question, otherwise everything LGTM!

Should the Options section of the Gallery Shortcode page have links to Codex page "How to Pass Tag Parameters", with respective subsection links? (integer, string etc.)

Other pages follow that kind of styling.

pekkakortelainen avatar Jun 14 '23 19:06 pekkakortelainen

@pekkakortelainen Thank you for the review.

If possible, I think that the Gallery Shortcode options should have the same information as other Shortcodes. However, the link should be to the PHP manual (e.g. https://www.php.net/manual/en/language.types.php), not the Codex, because it is deprecated.

atachibana avatar Jun 18 '23 14:06 atachibana

Heads up @docs-reviewers - the "[Status] Review" label was applied to this issue.

github-actions[bot] avatar Oct 17 '23 09:10 github-actions[bot]

/assign

flexseth avatar Mar 22 '24 12:03 flexseth

Hey @flexseth, thanks for your interest in this issue! 🍪🍪🍪
If you have any questions, do not hesitate to ask them in our #docs Slack channel.
Enjoy and happy contributing ❤️

github-actions[bot] avatar Mar 22 '24 12:03 github-actions[bot]