Documentation-Issue-Tracker
Documentation-Issue-Tracker copied to clipboard
[HelpHub] Content review: Video shortcode
Issue Description
Still contains links to Codex
URL of the Page with the Issue
Section of Page with the issue
Why is this a problem?
Are links still valid? Are there plans to bring the other shortcode articles into DevHub?
Suggested Fix
If needed, transfer the other shortcode articles into DevHub and move this article to DevHub as marked in #388
Heads up @lucprincen @javiercasares - the "advanced administration" label was applied to this issue.
Heads up @femkreations @atachibana - the "user documentation" label was applied to this issue.
I found other shortcode articles and these can be used in the code block so they can remain in en-user documentation.
Hi! I'll try to tackle this one as my first issue 🙌
I will check this.
Revised the codex links of the Video Shortcode page and below are the revised versions of the linked shortcode pages.
Caption Shortcode Updated the shortcode parameters, a couple were missing. https://docs.google.com/document/d/1ELKXlJ3-72N7HQstClApw3gFivu60SuutRTVIi7alJE/edit?usp=sharing
Embed Shortcode Updated some links from codex to the new documentation. https://docs.google.com/document/d/1812oZyG7BAabYxXldk4oGyeKeQNwP6iWPar5jWr9nm4/edit?usp=sharing
Gallery Shortcode Updated some links from codex that have a new version and updated the options section with the ids arguments. https://docs.google.com/document/d/1I7DmNA8BnUQM2AViP0SYmjkTA0S5fbnpPQiVyQ7SJrE/edit?usp=sharing
Playlist Shortcode Updated some links from codex that have a new version. https://docs.google.com/document/d/12KYTDMxEvQpQXEpwNkXehh4_vXvSLP7DoeNtUivn2gk/edit?usp=sharing
I'll review this as discussed in Slack :)
One question, otherwise everything LGTM!
Should the Options section of the Gallery Shortcode page have links to Codex page "How to Pass Tag Parameters", with respective subsection links? (integer, string etc.)
Other pages follow that kind of styling.
@pekkakortelainen Thank you for the review.
If possible, I think that the Gallery Shortcode options should have the same information as other Shortcodes. However, the link should be to the PHP manual (e.g. https://www.php.net/manual/en/language.types.php), not the Codex, because it is deprecated.
Heads up @docs-reviewers - the "[Status] Review" label was applied to this issue.
/assign
Hey @flexseth, thanks for your interest in this issue! 🍪🍪🍪
If you have any questions, do not hesitate to ask them in our #docs Slack channel.
Enjoy and happy contributing ❤️