Greg Woolsey

Results 58 comments of Greg Woolsey

Cognito "Hosted UI" (the OAUTH2 HTTPS end point documented [here](https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-userpools-server-contract-reference.html)) appears to be using the AWS SDK for JavaScript, but not at the latest version, and still exhibits this bug....

A bigger issue is that setting justify-content: flex-end breaks menu item overflow on small screens. Same with setting direction:rtl

Further, `LazyRefEval` is a concrete `final` class. That should be abstracted as far as possible as well. Similarly, `AreaEval` can be abstracted. I think this should be the final code...

This could be fairly simple, I think something like this added to `CrudGrid`: ``` public InputField createFilterField(Column column) { return new TextField(); } ``` Then, in `setupFiltering` just check if...

Oh, and returning `null` could indicate no filtering for that column.

I just realized this may not be the right issue for my comments, sorry. This was specific to custom/generated columns, not the general/default filter case, which is what I was...

Exploring further, why not store `HeaderRow filterRow` as a field, and initialize on first call to a new method: ```public InputField addDefaultFilter(Column column);``` Which is the body of the `forEach()`...

Looks like the only failures are the expected PhantomJS screenshots, which no longer have the "Fill" overlay.

I don't have access to an iPhone at them moment (only one around is my wife's, which is hard to pry out of her hands, even if she were home)....

I can reproduce the overlay display issue with core Vaadin, so it isn't a problem with the context menu changes themselves. To reproduce: Go to the [sample Charts app](https://demo.vaadin.com/charts/) Click...