speak-her-db icon indicating copy to clipboard operation
speak-her-db copied to clipboard

Disallow blank submissions

Open ann-kilzer opened this issue 5 years ago • 3 comments

Describe the bug The form should not be accepting content like this:

This is an automated message indicating a new speaker nomination:

Time: 2020-09-01T08:04:28.000Z
Name: /
Email:
Company:
Bio:
Submitted by:
Submitter Email:

To Reproduce Steps to reproduce the behavior:

  1. Go to https://speakher.jp/nominate-speaker
  2. Fill out the form... more investigation needed, because I can't get this to validate.
  3. Check the Airtable for a mostly-blank row

Expected behavior We shouldn't allow invalid, blank submissions

Additional context Add any other context about the problem here.

ann-kilzer avatar Sep 01 '20 08:09 ann-kilzer

Untitled

So I could reproduce this. If you check the network tab while sending in the form, both the database ID and the token are visible. (Don't want to create some test entry on production so I didn't check there, this is on my local)

I then copy pasted all of that into Postman, copy pasted the request body, set all fields to empty and I could create an entry with all fields empty.

I saw you want to add a backend for airtable access already, so maybe it should be prioritized? :)

Airtable dev db: image

dominikeinkemmer avatar Oct 01 '20 13:10 dominikeinkemmer

Yes we are aware of that in #15. Thanks for the helpful reproduction notes!

ann-kilzer avatar Oct 01 '20 13:10 ann-kilzer

oh sorry I missed that issue somehow 😅 I can help with setting up a backend if necessary :)

dominikeinkemmer avatar Oct 01 '20 14:10 dominikeinkemmer