CustomCrafting icon indicating copy to clipboard operation
CustomCrafting copied to clipboard

Using tags cause fail recipe loading

Open ArubikU opened this issue 1 year ago • 1 comments

What happened?

When i add a tag to a item the recipe fail on load, actually are two issues one relative to Tags and other to mmoitems cant load correctly items in async (i feel everything run good but the problem is the console yellow thingy, i hate it XD)

How can the bug be reproduced?

Add any tag to a item, using last wolfyutils of releases 4.17-beta1

Expected Behaviour?

Loading?

Plugin version

Customcrafting Last , WolfyUtils last

Server software

Current: git-Purpur-2160 (MC: 1.20.4)* Previous: git-Pufferfish-47 (MC: 1.20.4) * You are 15 version(s) behind Download the new version at: https://purpurmc.org/downloads

Relevant log output

[20:47:47 WARN]: [CustomCrafting] [LOCAL] [Error] Invalid Recipe: "customcrafting:food/obsalad": GenerateLoreEvent may only be triggered synchronously. (through reference chain: me.wolfyscript.customcrafting.recipes.CraftingRecipeShapeless["ingredients"]->java.util.ArrayList[0]->me.wolfyscript.customcrafting.recipes.items.Ingredient["items"]->java.util.ArrayList[0])
[20:47:47 WARN]: [CustomCrafting] [LOCAL] [Error]   Caused by: GenerateLoreEvent may only be triggered synchronously.
[20:47:47 WARN]: [CustomCrafting] [LOCAL] [Error] Invalid Recipe: "customcrafting:food/ketchup_1": GenerateLoreEvent may only be triggered synchronously. (through reference chain: me.wolfyscript.customcrafting.recipes.CraftingRecipeShapeless["ingredients"]->java.util.ArrayList[0]->me.wolfyscript.customcrafting.recipes.items.Ingredient["items"]->java.util.ArrayList[0])
[20:47:47 WARN]: [CustomCrafting] [LOCAL] [Error]   Caused by: GenerateLoreEvent may only be triggered synchronously.
[20:47:47 WARN]: [CustomCrafting] [LOCAL] [Error] Invalid Recipe: "customcrafting:food/foodbook": GenerateLoreEvent may only be triggered synchronously. (through reference chain: me.wolfyscript.customcrafting.recipes.CraftingRecipeShapeless["ingredients"]->java.util.ArrayList[0]->me.wolfyscript.customcrafting.recipes.items.Ingredient["items"]->java.util.ArrayList[0])
[20:47:47 WARN]: [CustomCrafting] [LOCAL] [Error]   Caused by: GenerateLoreEvent may only be triggered synchronously.
[20:47:47 WARN]: [CustomCrafting] [LOCAL] [Error] Invalid Recipe: "customcrafting:mmo/mix_crafting": GenerateLoreEvent may only be triggered synchronously. (through reference chain: me.wolfyscript.customcrafting.recipes.CraftingRecipeShaped["ingredients"]->java.util.LinkedHashMap["B"]->me.wolfyscript.customcrafting.recipes.items.Ingredient["items"]->java.util.ArrayList[0])
[20:47:47 WARN]: [CustomCrafting] [LOCAL] [Error]   Caused by: GenerateLoreEvent may only be triggered synchronously.
[20:47:48 WARN]: [CustomCrafting] [LOCAL] [Error] Invalid Recipe: "customcrafting:tac/crate": Cannot construct instance of `me.wolfyscript.customcrafting.recipes.items.Ingredient`, problem: 'void com.wolfyscript.utilities.bukkit.world.items.reference.StackReference.<init>(me.wolfyscript.utilities.api.WolfyUtilCore, me.wolfyscript.utilities.util.NamespacedKey, double, int, org.bukkit.inventory.ItemStack)'
 at [Source: (String); line: 123] (through reference chain: me.wolfyscript.customcrafting.recipes.CraftingRecipeShaped["ingredients"]->java.util.LinkedHashMap["A"])
[20:47:48 WARN]: [CustomCrafting] [LOCAL] [Error]   Caused by: 'void com.wolfyscript.utilities.bukkit.world.items.reference.StackReference.<init>(me.wolfyscript.utilities.api.WolfyUtilCore, me.wolfyscript.utilities.util.NamespacedKey, double, int, org.bukkit.inventory.ItemStack)'
[20:47:48 WARN]: [CustomCrafting] [LOCAL] [Error] Invalid Recipe: "customcrafting:tac/sawmill": Cannot construct instance of `me.wolfyscript.customcrafting.recipes.items.Ingredient`, problem: 'void com.wolfyscript.utilities.bukkit.world.items.reference.StackReference.<init>(me.wolfyscript.utilities.api.WolfyUtilCore, me.wolfyscript.utilities.util.NamespacedKey, double, int, org.bukkit.inventory.ItemStack)'
 at [Source: (String); line: 1] (through reference chain: me.wolfyscript.customcrafting.recipes.CraftingRecipeShaped["ingredients"]->java.util.LinkedHashMap["H"])
[20:47:48 WARN]: [CustomCrafting] [LOCAL] [Error]   Caused by: 'void com.wolfyscript.utilities.bukkit.world.items.reference.StackReference.<init>(me.wolfyscript.utilities.api.WolfyUtilCore, me.wolfyscript.utilities.util.NamespacedKey, double, int, org.bukkit.inventory.ItemStack)'
[20:47:48 WARN]: [CustomCrafting] [LOCAL] [Error] Invalid Recipe: "customcrafting:tweaks/chest2": Cannot construct instance of `me.wolfyscript.customcrafting.recipes.items.Ingredient`, problem: 'void com.wolfyscript.utilities.bukkit.world.items.reference.StackReference.<init>(me.wolfyscript.utilities.api.WolfyUtilCore, me.wolfyscript.utilities.util.NamespacedKey, double, int, org.bukkit.inventory.ItemStack)'
 at [Source: (String); line: 1] (through reference chain: me.wolfyscript.customcrafting.recipes.CraftingRecipeShaped["ingredients"]->java.util.LinkedHashMap["H"])
[20:47:48 WARN]: [CustomCrafting] [LOCAL] [Error]   Caused by: 'void com.wolfyscript.utilities.bukkit.world.items.reference.StackReference.<init>(me.wolfyscript.utilities.api.WolfyUtilCore, me.wolfyscript.utilities.util.NamespacedKey, double, int, org.bukkit.inventory.ItemStack)'

Submit issue

  • [X] read the Wiki and especially the FaQ, and made sure there is no fix to your issue,
  • [X] searched for and ensured there isn't already an open issue regarding this,
  • [X] are running the latest version of your server software (Spigot, Paper, etc.), and plugins (WolfyUtilities, CustomCrafting).

ArubikU avatar May 07 '24 20:05 ArubikU

The StackReference issue will be fixed in WolfyScript/WolfyUtils-Spigot#82 by https://github.com/WolfyScript/WolfyUtils-Spigot/pull/82/commits/21f4c3352004b88c44bd06df269a72ba48cabdf6 So next beta update should fix it, however I'm not able to give any ETA.

For the MMOItems issue, I'll keep you updated here #367

WolfyScript avatar May 17 '24 12:05 WolfyScript