Shiori icon indicating copy to clipboard operation
Shiori copied to clipboard

UI Improments

Open tommyvct opened this issue 3 years ago • 1 comments

  1. The +1 and -1 icon should be just a single plus or minus sign. The key information is the level number, and the number in +1 and -1 icons are confusing and distracting. ref https://github.com/Wolfteam/GenshinDb/blob/main/lib/presentation/shared/increment_button.dart#L36. image

  2. Lack of padding space or line between level, ascension, and talents. You have padding line between talent's name and current & desired levels, but not for elsewhere. In another word, the division between different section is unclear. According to Gestalt law of proximity, this is what I saw: image

  3. Level picker should be an integer only text box, instead of a scrolling number picker dialogue. Scrolling through 90 numbers isn't ergonomic. ref https://github.com/Wolfteam/GenshinDb/blob/main/lib/presentation/calculator_asc_materials/widgets/add_edit_item_bottom_sheet.dart#L143 image

  4. The character's picture is distorted.

  5. I noticed the materials for certain character or weapon is scrollable, but it's not clearly indicated. There is a better way to show materials breakdown by character/weapon, maybe a spreadsheet would work. I'll let you know if I have any other ideas.

  6. You should make more space for item name. That Edit icon is functionally useless, and the delete button can be merged into add_edit_item_bottom_sheet. image

  7. Teachings of What? The same thing applies to other ascension materials. image

tommyvct avatar Mar 21 '21 07:03 tommyvct

Hiho, took me a while to answer this one...

1)This was changed (can't remember which version)

2)I think the current spacing is ok

3)I still prefer the dialog here

4)Yep, some pictures are not high res. to avoid making the app size bigger, although, will try to make them a litte bit bigger

5)You mean the ones in the home page ? I also don't know how to indicate that those are horizontally scrollable

6)This was also fixed

7)I had to trim the names cause it will look weird if some card are bigger than others, you can check the whole name by long tapping on them

Wolfteam avatar Jul 25 '21 17:07 Wolfteam