BlossomsPokemonGoManager icon indicating copy to clipboard operation
BlossomsPokemonGoManager copied to clipboard

Show last used patterns (maybe with favorites)

Open Hannott opened this issue 9 years ago • 9 comments

When renaming, it would be nice to have some default schemes. I rename all mine with IV-att/def/sta (98-15/15/14). Would be nice to just have a %iv_stats% parameter for this.

Hannott avatar Aug 19 '16 06:08 Hannott

We had that, but it is very specific. Guess it is better to keep the patterns as short as possible so that you can combine them in any way you want.

What is possible and would be cool though is that you have a list of your last entered renames where you can easily select some, maybe even with a favorite feature so that it always stays on top of that list. I'll keep that issue open for that.

(Btw, you can use the IV hexadecimal pattern, which has all three and even uses just three characters of the name :P )

Wolfsblvt avatar Aug 19 '16 12:08 Wolfsblvt

Yeah, it's very specific, but I assume a lot of people would use the same naming schemes if a few good default ones were available.

This is very clunky: %iv_rating%-%iv_att%/%iv_def%/%iv_stam%

To not clutter it up, it could be added to a dropdown. Favorites would be nice, but that's more work, and I assume is lost when you get the next version. You could put it in config of course, but a lot of things end up in config after a while, and it gets cluttery

Hannott avatar Aug 20 '16 07:08 Hannott

I've just implemented a "show last used" pattern. Stores in config.json file and load when the panel opens. How do I send a merge request? Do I need to open an issue? Or just commit in the developer branch?

FernandoTBarros avatar Aug 23 '16 01:08 FernandoTBarros

@FernandoTBarros Submit a pull request to the develop branch

Hannott avatar Aug 23 '16 05:08 Hannott

Yep. Make a pull request from your branch to the developer branch, then your code gets reviewed and will eventually be merged, if everything is alright.

Wolfsblvt avatar Aug 23 '16 10:08 Wolfsblvt

OK Done! I didn't associate this issue with the merge request. It's a good thing to do?

FernandoTBarros avatar Aug 24 '16 13:08 FernandoTBarros

You can mark this done @Wolfsblvt. Going in and out of Manager and back in, saves the last used pattern in field.

ISeeTanamon avatar Sep 16 '16 00:09 ISeeTanamon

I think he kept this opened because of the "favorite" part. It's an interesting idea have your last used patterns, or a place for organizing your renaming patterns.

FernandoTBarros avatar Sep 16 '16 00:09 FernandoTBarros

Yep, exactly that. I guess many will have similar things like me. I name my fighters (attackers and defenders) other than the Pokémon I just want to evolve, so I need at least two rename patterns that I will use very regularly.

Would be a cool feature for the new UI.

Wolfsblvt avatar Sep 16 '16 08:09 Wolfsblvt