ArmorStandEditor Bump actions/upload-artifact from 4.0.0 to 4.3.2

Bumps actions/upload-artifact from 4.0.0 to 4.3.2.

Release notes

Sourced from actions/upload-artifact's releases.

v4.3.2

What's Changed

Update release-new-action-version.yml by @konradpabjan in actions/upload-artifact#516

Minor fix to the migration readme by @andrewakim in actions/upload-artifact#523

Update readme with v3/v2/v1 deprecation notice by @robherley in actions/upload-artifact#561

updating @actions/artifact dependency to v2.1.5 and @actions/core to v1.0.1 by @eggyhead in actions/upload-artifact#562

New Contributors

@andrewakim made their first contribution in actions/upload-artifact#523

Full Changelog: https://github.com/actions/upload-artifact/compare/v4.3.1...v4.3.2

v4.3.1

Bump @actions/artifacts to latest version to include updated GHES host check

v4.3.0

What's Changed

Reorganize upload code in prep for merge logic & add more tests by @robherley in actions/upload-artifact#504

Add sub-action to merge artifacts by @robherley in actions/upload-artifact#505

Full Changelog: https://github.com/actions/upload-artifact/compare/v4...v4.3.0

v4.2.0

What's Changed

Ability to overwrite an Artifact by @robherley in actions/upload-artifact#501

Full Changelog: https://github.com/actions/upload-artifact/compare/v4...v4.2.0

v4.1.0

What's Changed

Add migrations docs by @robherley in actions/upload-artifact#482

Update README.md by @samuelwine in actions/upload-artifact#492

Support artifact-url output by @konradpabjan in actions/upload-artifact#496

Update readme to reflect new 500 artifact per job limit by @robherley in actions/upload-artifact#497

New Contributors

@samuelwine made their first contribution in actions/upload-artifact#492

Full Changelog: https://github.com/actions/upload-artifact/compare/v4...v4.1.0

Commits

1746f4a Revert "updating to release 4.3.2"
31685d0 updating to release 4.3.2
18bf333 Merge pull request #562 from actions/eggyhead/update-artifact-v215
dac413b update package lock version
bb3b4a3 updating package version
3e3da83 updating artifact and core dependencies
e35774f Merge pull request #561 from actions/robherley/deprecation-notice
e63ea67 Update readme with v3/v2/v1 deprecation notice
ef09cda Merge pull request #523 from andrewakim/andrewakim/migration-readme-fix
00e36f9 Minor fix to the migration readme
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Apr 22 '24 01:04 dependabot[bot]

My guess is that input_error is supposed to be the equivalent of the famous BLAS function, xerbla, and is provided in many BLAS implementations . Windows linking is very difficult with circular references. I build SuperLU 5.3 on windows as a static libraries without any blas, by tricking it with -DBLAS_FOUND=ON on the cmake command line.

cmake  -DCMAKE_C_FLAGS="/fp:strict" -Denable_complex=OFF -Denable_single=OFF -Denable_doc=OFF -Denable_tests=OFF -DXSDK_ENABLE_Fortran=OFF -DBLAS_FOUND=ON ..

Then when I link the application, I choose my favorite blas implementation, which hopefully has its own self contained error handling.

If you must have dynamic libraries and want the CBLAS, I suggest copying SRC/input_error.c into CBLAS and adding it into the CBLAS/CMakeLists.txt.

Jan 26 '23 17:01 tcaduser

I think it's a good suggestion from @tcaduser . I updated the master branch. This will be in the next release.

Jan 30 '23 01:01 xiaoyeli

Is that sufficient? There are several other unresolved external symbols beyond input_error, like r_imag, r_cnjg, d_imag, d_cnjg, c_div, z_div.

Also, why did this only begin in 5.3.0? Building in 5.2.1 succeeds. Was the code significantly rearchitected?

Jan 30 '23 17:01 alexchandel

@xiaoyeli adding input_error.c to CBLAS/CMakeLists.txt seems to break the build.

Feb 06 '23 05:02 alexchandel

Working through the build, this isn't limited to input_error(), or to Windows. CBLAS references a half-dozen symbols defined in superlu, leading to link errors:

$ VERBOSE=1 cmake .. -Denable_internal_blaslib=YES && cmake --build .                                   
Re-run cmake no build system arguments

Process XSDK defaults ...
USE_XSDK_DEFAULTS = 'TRUE'
-- XSDK: Setting default BUILD_SHARED_LIBS=TRUE
-- XSDK: Setting default CMAKE_BUILD_TYPE=DEBUG
-- SuperLU will be built as a shared library.
-- The C compiler identification is AppleClang 14.0.0.14000029
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- The Fortran compiler identification is GNU 12.2.0
-- Checking whether Fortran compiler has -isysroot
-- Checking whether Fortran compiler has -isysroot - yes
-- Checking whether Fortran compiler supports OSX deployment target flag
-- Checking whether Fortran compiler supports OSX deployment target flag - yes
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - done
-- Check for working Fortran compiler: /usr/local/bin/gfortran - skipped
-- Did not find or specify BLAS so configure to build internal CBLAS ...
-- Configuring done
CMake Warning (dev):
  Policy CMP0042 is not set: MACOSX_RPATH is enabled by default.  Run "cmake
  --help-policy CMP0042" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  MACOSX_RPATH is not specified for the following targets:

   blas
   matgen
   superlu

This warning is for project developers.  Use -Wno-dev to suppress it.

-- Generating done
-- Build files have been written to: /Users/dev/Git/superlu/build
[  0%] Building C object CBLAS/CMakeFiles/blas.dir/input_error.c.o
[  0%] Building C object CBLAS/CMakeFiles/blas.dir/isamax.c.o
[  0%] Building C object CBLAS/CMakeFiles/blas.dir/sasum.c.o
[  1%] Building C object CBLAS/CMakeFiles/blas.dir/saxpy.c.o
[  1%] Building C object CBLAS/CMakeFiles/blas.dir/scopy.c.o
[  1%] Building C object CBLAS/CMakeFiles/blas.dir/sdot.c.o
[  2%] Building C object CBLAS/CMakeFiles/blas.dir/snrm2.c.o
[  2%] Building C object CBLAS/CMakeFiles/blas.dir/srot.c.o
[  2%] Building C object CBLAS/CMakeFiles/blas.dir/sscal.c.o
[  2%] Building C object CBLAS/CMakeFiles/blas.dir/sswap.c.o
[  3%] Building C object CBLAS/CMakeFiles/blas.dir/sgemv.c.o
[  3%] Building C object CBLAS/CMakeFiles/blas.dir/ssymv.c.o
[  3%] Building C object CBLAS/CMakeFiles/blas.dir/strsv.c.o
[  4%] Building C object CBLAS/CMakeFiles/blas.dir/sger.c.o
[  4%] Building C object CBLAS/CMakeFiles/blas.dir/ssyr2.c.o
[  4%] Building C object CBLAS/CMakeFiles/blas.dir/idamax.c.o
[  4%] Building C object CBLAS/CMakeFiles/blas.dir/dasum.c.o
[  5%] Building C object CBLAS/CMakeFiles/blas.dir/daxpy.c.o
[  5%] Building C object CBLAS/CMakeFiles/blas.dir/dcopy.c.o
[  5%] Building C object CBLAS/CMakeFiles/blas.dir/ddot.c.o
[  6%] Building C object CBLAS/CMakeFiles/blas.dir/dnrm2.c.o
[  6%] Building C object CBLAS/CMakeFiles/blas.dir/drot.c.o
[  6%] Building C object CBLAS/CMakeFiles/blas.dir/dscal.c.o
[  6%] Building C object CBLAS/CMakeFiles/blas.dir/dswap.c.o
[  7%] Building C object CBLAS/CMakeFiles/blas.dir/dgemv.c.o
[  7%] Building C object CBLAS/CMakeFiles/blas.dir/dsymv.c.o
[  7%] Building C object CBLAS/CMakeFiles/blas.dir/dtrsv.c.o
[  8%] Building C object CBLAS/CMakeFiles/blas.dir/dger.c.o
[  8%] Building C object CBLAS/CMakeFiles/blas.dir/dsyr2.c.o
[  8%] Building C object CBLAS/CMakeFiles/blas.dir/icamax.c.o
[  8%] Building C object CBLAS/CMakeFiles/blas.dir/scasum.c.o
[  9%] Building C object CBLAS/CMakeFiles/blas.dir/caxpy.c.o
[  9%] Building C object CBLAS/CMakeFiles/blas.dir/ccopy.c.o
[  9%] Building C object CBLAS/CMakeFiles/blas.dir/scnrm2.c.o
[ 10%] Building C object CBLAS/CMakeFiles/blas.dir/cscal.c.o
[ 10%] Building C object CBLAS/CMakeFiles/blas.dir/cswap.c.o
[ 10%] Building C object CBLAS/CMakeFiles/blas.dir/cdotc.c.o
[ 10%] Building C object CBLAS/CMakeFiles/blas.dir/cgemv.c.o
[ 11%] Building C object CBLAS/CMakeFiles/blas.dir/chemv.c.o
[ 11%] Building C object CBLAS/CMakeFiles/blas.dir/ctrsv.c.o
[ 11%] Building C object CBLAS/CMakeFiles/blas.dir/cgerc.c.o
[ 12%] Building C object CBLAS/CMakeFiles/blas.dir/cher2.c.o
[ 12%] Building C object CBLAS/CMakeFiles/blas.dir/izamax.c.o
[ 12%] Building C object CBLAS/CMakeFiles/blas.dir/dzasum.c.o
[ 13%] Building C object CBLAS/CMakeFiles/blas.dir/zaxpy.c.o
[ 13%] Building C object CBLAS/CMakeFiles/blas.dir/zcopy.c.o
[ 13%] Building C object CBLAS/CMakeFiles/blas.dir/dznrm2.c.o
[ 13%] Building C object CBLAS/CMakeFiles/blas.dir/zscal.c.o
[ 14%] Building C object CBLAS/CMakeFiles/blas.dir/dcabs1.c.o
[ 14%] Building C object CBLAS/CMakeFiles/blas.dir/zswap.c.o
[ 14%] Building C object CBLAS/CMakeFiles/blas.dir/zdotc.c.o
[ 15%] Building C object CBLAS/CMakeFiles/blas.dir/zgemv.c.o
[ 15%] Building C object CBLAS/CMakeFiles/blas.dir/zhemv.c.o
[ 15%] Building C object CBLAS/CMakeFiles/blas.dir/ztrsv.c.o
[ 15%] Building C object CBLAS/CMakeFiles/blas.dir/zgerc.c.o
[ 16%] Building C object CBLAS/CMakeFiles/blas.dir/zher2.c.o
[ 16%] Linking C shared library libblas.dylib
Undefined symbols for architecture x86_64:
  "_c_div", referenced from:
      _ctrsv_ in ctrsv.c.o
  "_d_cnjg", referenced from:
      _zdotc_ in zdotc.c.o
      _zgemv_ in zgemv.c.o
      _zhemv_ in zhemv.c.o
      _ztrsv_ in ztrsv.c.o
      _zgerc_ in zgerc.c.o
      _zher2_ in zher2.c.o
  "_d_imag", referenced from:
      _dznrm2_ in dznrm2.c.o
  "_r_cnjg", referenced from:
      _cdotc_ in cdotc.c.o
      _cgemv_ in cgemv.c.o
      _chemv_ in chemv.c.o
      _ctrsv_ in ctrsv.c.o
      _cgerc_ in cgerc.c.o
      _cher2_ in cher2.c.o
  "_r_imag", referenced from:
      _icamax_ in icamax.c.o
      _scasum_ in scasum.c.o
      _caxpy_ in caxpy.c.o
      _scnrm2_ in scnrm2.c.o
  "_z_div", referenced from:
      _ztrsv_ in ztrsv.c.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [CBLAS/libblas.dylib] Error 1
make[1]: *** [CBLAS/CMakeFiles/blas.dir/all] Error 2
make: *** [all] Error 2

Feb 06 '23 06:02 alexchandel