jumpcutter icon indicating copy to clipboard operation
jumpcutter copied to clipboard

improvement: use different `volumeThreshold` for different algorithms

Open WofWca opened this issue 3 years ago • 1 comments

Margins are already on the list. https://github.com/WofWca/jumpcutter/blob/6f82c4494e6bcbf5ed1b4854410f0921a3a01d8a/src/settings/defaultSettings.ts#L60-L68

Also maybe silenceSpeed also needs to be added there, although it's not used in the cloning algorithm yet.

The reason I think we need this is because with the cloning algorithm you don't really need to set volumeThreshold as low as possible because marginBefore actually works properly there without any stretching.

WofWca avatar Jun 03 '22 14:06 WofWca

Oh BTW maybe we should simply make the one setting a multiplier of another setting? E.g. when you switch to the cloning algorithm, just multiply margins by two.

WofWca avatar Aug 16 '22 13:08 WofWca