WofWca
WofWca
Aight my dudes, after 4 years in development, hopefully it would have been worth the wait. The prototype is working on YouTube! https://github.com/WofWca/jumpcutter/assets/39462442/3070927e-52a7-4468-b5a2-ca349a806f9c Here's the build that you can play...
> unless they were implemented with that use case in mind @Johni0702 could you please clarify how this can be done?
> That's something the website author would have to have done I mean, if they were to have done it, how would it work?
I mean, how would the website maker implement it? Sorry XD
Thanks again for the input! It's extremely satisfying to implement it after all this time! And let's not stop here. If someone has another approach in mind, please share.
Someone in the reviews on Chrome Web Store also suggested a wildcard-type whitelist/blacklist, in order to only enable the extension for certain playlists on YouTube.
Related: https://github.com/vantezzen/skip-silence/issues/139
@LoneCoder21 It's this check https://github.com/WofWca/jumpcutter/blob/81b4e507b68d9f7c50e90161326edc65038ae28c/src/entry-points/content/helpers/isSourceCrossOrigin.ts#L37 See the comment: https://github.com/WofWca/jumpcutter/blob/c63821f8f61c41f66f790018f795db49778b0c14/src/entry-points/content/AllMediaElementsController.ts#L96-L115 So it's not like we detect an actual likelihood expressed as a number between 0 and 100%, but rather "it's cross-origin,...
This also applies to the `'unavailable-id'` error (the reconnect case). That is, you have no context as to which peer the error relates to. Responsible source code: https://github.com/peers/peerjs/blob/633cd84929f398899a06e8281706e3040410d706/lib/peer.ts#L390-L395 I think...
What I mean is that I think this should be reflected in the book. Or does it still hold?