WoeUSB-ng icon indicating copy to clipboard operation
WoeUSB-ng copied to clipboard

Published 20 hours ago • verified publisher icon WoeUSB

fix python packaging using latest methods

Open hsbasu opened this issue 2 years ago • 11 comments

  • Change python packaging method following instructions from https://packaging.python.org/en/latest/tutorials/packaging-projects/
  • Remove scripts as they can be created automatically from setup.cfg
  • move the sources to src
  • setup.py: remove captialization in package names, conflicts with other packaging methods like debian's
  • modify licence to gpl3+
  • Add setup.cfg and pyproject.toml
  • modify MANIFEST.in to include assets
  • WoeUSB-ng.desktop: add version and change icon; fixes #11

hsbasu avatar Jun 09 '22 04:06 hsbasu

~~Please separate your changes into individual pull requests, each change should have a rationale to indicate why those changes are necessary and/or beneficial to the project.~~

brlin-tw avatar Jun 09 '22 04:06 brlin-tw

If I follow the latest python packaging guide (Link in Commit), this is the minimal change that was required. I just moved the sources to src and added latest python packaging methods i.e. adding the setup.cfg and pyproject.toml.

hsbasu avatar Jun 09 '22 04:06 hsbasu

Got it, thanks for the explanation.

brlin-tw avatar Jun 09 '22 04:06 brlin-tw

Please separate your changes into individual pull requests, each change should have a rationale to indicate why those changes are necessary and/or beneficial to the project.

The changes were required, as I mentioned in commit, to package it for debian and others.

hsbasu avatar Jun 09 '22 04:06 hsbasu

I would suggest do not merge it yet. because the setup.py needs to be cleaned. It would be highly appreciated if you could test the branch. just use pip3 install .. no need to use sudo

hsbasu avatar Jun 09 '22 04:06 hsbasu

I would also suggest while merging use the Squash and merge option rather than creating a new commit

hsbasu avatar Jun 09 '22 04:06 hsbasu

@brlin-tw you can merge the branch. I have completed all the necessary changes and it works fine.

hsbasu avatar Jun 13 '22 15:06 hsbasu

@brlin-tw A gente reminder that the PR is ready for merge. Thank you.

hsbasu avatar Jul 23 '22 18:07 hsbasu

@brlin-tw Hi. Is this PR going to get merged or should I close this as incomplete?

hsbasu avatar Feb 15 '23 15:02 hsbasu

Hi @hsbasu, thanks for PR. I'm sorry for ignoring this, I had a lot on my head for some time now. I'll try to go over those changes as soon as possible.

WaxyMocha avatar Feb 19 '23 16:02 WaxyMocha

FYI, I use this PR without issue to build the aur package available at https://aur.archlinux.org/packages/woeusb-ng.

The pkgbuild file that show the build process is available here.

I'll subscribe to this thread to be notified about the merge to update the package. I can provide help with test or feedback for this PR if needed.

BarbUk avatar Jul 01 '23 08:07 BarbUk