WoWAnalyzer icon indicating copy to clipboard operation
WoWAnalyzer copied to clipboard

Fix husky on windows

Open emallson opened this issue 1 year ago • 3 comments

Reported by @jazminite

meant to get to it today but didn't. this is a reminder.

issues are:

  • use of husky install is deprecated https://github.com/typicode/husky/releases/tag/v9.0.1
  • Yarn/Windows specific breakage: https://typicode.github.io/husky/troubleshoot.html#yarn-on-windows

The fix in the 2nd doc should be safe to put in the main repository but needs testing

emallson avatar Jul 16 '24 00:07 emallson

Husky works fine on windows as-is on the-war-within branch. What specific issue is appearing? Also, husky install is already removed on that branch too, I did that in https://github.com/WoWAnalyzer/WoWAnalyzer/commit/cc6cf5286238600c144e94754f4421e110e4d3e0

I tested on both windows terminal and git bash, both work fine 🤔

Pewtro avatar Jul 16 '24 00:07 Pewtro

EDIT removed image because i realized it had an email address in it image

this is what Jaz sent me, which matches the issue listed on the troubleshooting page

emallson avatar Jul 16 '24 00:07 emallson

I personally work on windows but dont seem to get these errors. Does this have to do with the changes to pnpm?

danny-janse avatar Oct 03 '24 13:10 danny-janse