WoWAnalyzer icon indicating copy to clipboard operation
WoWAnalyzer copied to clipboard

Switch to v2 WCL API

Open emallson opened this issue 3 years ago • 4 comments

The v2 API will allow us to do things like collecting reports for a logged-in user and accessing private reports, as well as other new features that may come down the pipeline later (generally speaking, the v1 API doesn't get new features).

This is primarily a backend task. This issue does not cover building out support for new things (like logging in, or private reports). Only for migrating the existing API usage to v2.

As part of this, it wouldn't hurt to do some TypeScripting of the backend :)

emallson avatar Sep 27 '22 19:09 emallson

Is the goal for this:

  1. have the WoWA UI make gQL calls to the WoWA->WCL proxy and the proxy makes gQL calls to WCL (frontend and backend change)
  2. have the WoWA UI make HTTP calls to the WoWA->WCL proxy and the proxy makes the gQL calls to WCL (backend change)

ToppleTheNun avatar Nov 10 '22 01:11 ToppleTheNun

I'm going to be looking a bit at what is involved. We can have the WoWA backend provide its own API that translates to the WCL API---that is likely the safest option to avoid people using the WoWA backend as a proxy for the WCL api and blowing our budget with extremely complex gql queries.

But this hasn't been totally sorted yet.

emallson avatar Nov 10 '22 01:11 emallson

WoWAnalyzer/server would be the repo for these changes, right?

ToppleTheNun avatar Nov 10 '22 14:11 ToppleTheNun

it depends:tm:

this one should probably just be left to me, since I'm able to make changes to the WCL API to accommodate our needs (I'm actually working on one right now for classic support)

emallson avatar Nov 10 '22 21:11 emallson