Wiznet
Add fixes and improvements from Micropython
An earlier version of this Wiznet driver has been in use in micropython (primarily on the stm32 port) since 2014, with a few additions being made to it since.
As part of my work in https://github.com/micropython/micropython/pull/8540 I'm updating the driver to use the current version from here, preferably as a submodule to make future updates easier to maintain. For this to happen smoothly though, I'm hoping to submit a clean version of the micropython patches here.
There are a couple of commits here that as-is will present no change, but instead allow third part projects like micropython to integrate the library more smoothly.
A couple of other commits add features / bug fixes found previously. Hopefully the commit descriptions provide enough context for these changes.
Sorry. We can't merge micropython related code here. This repository is a library for C language. For that code, it seems that we need to create a separate library for MicroPython.
Hi @irinakim12 this PR does not include any micropython specific code, it was carefully cleaned up to only include C changes that should be relevant to any users of this library. I listed micropython in the title simply because these were commits / changes originally done by other's under the micropython project.
Hi @irinakim12 I'm from the MicroPython project. We're currently using @andrewleech's fork of this repo but would prefer to point our submodule to the official repo instead.
As Andrew said, this PR doesn't include anything MicroPython-specific, rather it's just general improvements that make it easy for a project (such as MicroPython) to embed this library. (In particular, avoiding name collisions with other functions).
Sure, what's the question?
I write the review about your Pull request last week. I ask you for an answer and code fix for this.
I write the review about your Pull request last week. I ask you for an answer and code fix for this.
Sorry I can't see any review comments on this PR?
Do you mean a discussion on one/some of the "Change MICROPY_PY_LWIP setting" PR's in micropython?
I write the review about your Pull request last week. I ask you for an answer and code fix for this.
Sorry I can't see any review comments on this PR? Do you mean a discussion on one/some of the "Change MICROPY_PY_LWIP setting" PR's in micropython?
sorry. Review of this PR has been put on hold. Now you can check out my comments.