ioLibrary_Driver icon indicating copy to clipboard operation
ioLibrary_Driver copied to clipboard

Compiler warnings

Open allenhuffman opened this issue 4 years ago • 2 comments

We recently built this library for a PIC24 on the CCS compiler. There are a number of code warnings. Some might be easy to resolve in the standard code, and others are the "I know what I am doing" type that would be compiler-specific to ignore. Here are some examples:

socket.c:

// 214 - Operator precedance rules may not be as intended, use () to clarify 524) if((taddr == 0) && (getSn_MR(sn)&Sn_MR_MACRAW != Sn_MR_MACRAW)) return SOCKERR_IPINVALID; if((port == 0) && (getSn_MR(sn)&Sn_MR_MACRAW != Sn_MR_MACRAW)) return SOCKERR_PORTZERO;

// 215 - Undefined identifier W5300 708) #if WIZCHIP == W5300

// 237 - Extra comma 67) static uint16_t sock_remained_size[WIZCHIP_SOCK_NUM] = {0,0,}; 71) uint8_t sock_pack_info[WIZCHIP_SOCK_NUM] = {0,};

These would require compiler-specific ignores, so I don't know if there is anything that could be done in the master source:

// 203 - Condition always TRUE // 204 - Condition always FALSE

Can someone crank up the compiler warnings on a different compiler and see if these warnings exist there as well?

allenhuffman avatar May 03 '21 15:05 allenhuffman