Incorrect Socket Flag for Non-Blocking Sockets

Open osborners opened this issue 3 years ago • 0 comments

SOCK_IO_NONBLOCK is not a socket flag option for socket(), as used here in loopback.c: https://github.com/Wiznet/io6Library/blob/a52bd527491b8c7e1bcfdd6f54eb00fdb7a44c9b/Application/loopback/loopback.c#L141 It should be SF_IO_NONBLOCK.

However, the change introduced here means that only SOCK_IO_NONBLOCK will set the socket mode to non-blocking: https://github.com/Wiznet/io6Library/commit/c9c9ef8b209dc23a7908fe337976597f96c09c55#diff-5779d7831ac938e3f7d8cb0c0890060576acc6536afff3c010e7838367c7d9b3R172

21/05/24: A side effect of using SOCK_IO_NONBLOCK (=1) is that 'Force ARP' mode in Sn_MR2 gets enabled: https://github.com/Wiznet/io6Library/blob/master/Ethernet/socket.c#L163

Apr 28 '22 04:04 osborners