Matthew Gajownik

As we're partially breaking existing themes as part of 28 anyway, what if we just restructure this widget so that hacks like this aren't necessary any more? We've had to...

Ah, that's a bummer. Thanks for looking into it.

As long as the state on startup is logged, that should be fine.

The eye symbol is consistent with our Filters dialog, including audio filters.

Heads up, there are merge conflicts.

UX-wise it does feel weird that the properties section displays "No properties available" when a script is disabled but selected. Outside of that, this seems to do what it says...

This sounds like an ffmpeg issue, not an OBS issue. We don't choose the ffmpeg version on Linux, that's controlled by the package manager.

This seems to be the line the warning is about for `global_quality`: https://github.com/obsproject/obs-studio/blob/2a7fd297e48d05aec9784bad33946352a1a78e83/plugins/obs-ffmpeg/obs-ffmpeg-nvenc.c#L210

"NVENC not functioning properly" could be caused by two issues: 1. ffmpeg is doing something wrong (potentially entirely out of our control) 2. the warnings are indicators of misconfiguration on...

I can confirm this doesn't seem to break/remove any existing functionality. Will do a code review separately later.