Matt Gajownik

Results 181 comments of Matt Gajownik

This diff looks less like a bugfix and more of a hack. I don't believe it's a good idea to _assume_ `loopback_module_available()` is true on unsupported platforms. I am, however,...

Is this considered standard practice, or a hack due to some other behaviour (either elsewhere in the library or in the app interacting with the virtual camera)?

I have tried to fight this in like 30 different ways. The same issue exists for both OAuth dialogs like Twitch, and custom browser docks. It'll also cause hotkeys to...

I'd personally vote for us to add a clang-format ignore rule for this subdirectory rather than us reformatting an imported dependency. https://github.com/obsproject/obs-studio/blob/a9352985c797a3a0fe75ae8ba89013f30dc4b5ab/deps/blake2/.clang-format#L1-L3

I absolutely agree with deprecating `obs_get_transition_by_name`, but have less confidence in deprecating `obs_get_transition_by_uuid`, as the internals could change in the future and having them separate could be useful. Generally if...

The app in the screenshot does not seem to be an official app? The standard Xbox app should capture fine.

As a note, I just verified that UWP capture of the Xbox app on Windows 10 does work as expected. I can confirm I'm having issue on Windows 11, but...

Do not use merge commits, rebase is preferred.

I feel that our CMake flow shouldn't allow generating with a UUID that doesn't match our convention. I'd be curious what protections we provide already when it comes to building...

Out of curiosity, how do akvcam and droidcam handle the mapping? Is there something we could be doing better automatically?