wirecloud icon indicating copy to clipboard operation
wirecloud copied to clipboard

Added protocol to Via Header

Open JoaoSandrini opened this issue 11 months ago • 3 comments

Proposed changes

Changed the way the via header is constructed in order to enable compatibility with other NGSI-LD Context Brokers such as Scorpio Broker

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added necessary documentation (if appropriate)
  • [x] Any dependent changes have been merged and published in downstream modules

Further comments

Added the protocol to the via header, in order to enable compatibility with other NGSI-LD Context Brokers such as Scorpio Broker. Now its constructed like /<protocolVersion> <current_domain> (Wirecloud-python-Proxy/1.1). Tested it in a local environment and works, not sure how to implement the tests to comprove but i'm up to learn how to or help with it if needed.

JoaoSandrini avatar Feb 07 '25 16:02 JoaoSandrini

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Feb 07 '25 16:02 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

JoaoSandrini avatar Feb 07 '25 16:02 JoaoSandrini

Wirecloud creates a valid Via header, it’s Scorpio the one that does not accept it because of a logic bug in its code which I fixed in https://github.com/ScorpioBroker/ScorpioBroker/pull/614

oxixes avatar Mar 06 '25 22:03 oxixes