wirecloud icon indicating copy to clipboard operation
wirecloud copied to clipboard

Fix CI

Open dmunozv04 opened this issue 1 year ago • 1 comments

Proposed changes

CI had a couple of issues. First, since ubuntu 22.04, the actions runner has grunt preinstalled so there's no need for us to install it. Also, it now only attempts to login to docker hub and quay.io if its environment variable has been set

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x] I have read the CONTRIBUTING doc
  • [x] I have signed the CLA
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added necessary documentation (if appropriate)
  • [x] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

dmunozv04 avatar Nov 12 '24 16:11 dmunozv04