Anton

Results 248 comments of Anton

copy icons from other icon packs is unacceptable

Is it still needed? `Composer\InstalledVersions` contains similar functionality.

What's problem? SRP + ISP(SOLID) - separate interfaces and use as compositions. Sometimes possible downgrade type of parameters in extends: `interface::method(array $rows);` > `class::method(iterable $rows);` + type covariance >= 7.4....

Real problem is methods like as [BaseConnection::query](https://github.com/codeigniter4/CodeIgniter4/blob/develop/system/Database/BaseConnection.php#L619) - `@return BaseResult|Query|boolean` - no common entry points, that's code hard to validate and maintain. ~~~php interface ResultInterface { public function getState(): bool;...

@ MGatner I'm have same problems before and discover how do it other teams: - start voting "What's better: rework to modern solutions or keep BC & legacy code" -...

@bikash1317 it's not critical errors, but project in stagnation

@CreaturesInUnitards FF 73 (latest) ![изображение](https://user-images.githubusercontent.com/3521094/75173639-3fe95080-5740-11ea-9dad-4c9782703dd2.png)

unuseful component

> Tried adding the following tests, but they don't seem to work for some reason you can try add anchors `/^...$/i` or use `expectWarningMessage()`

Second method pack :) ~~~php /** * Computes the intersection of arrays by keys. * * @param iterable $array Source array. * @param array[] $keys Keys to extract data. *...