Christmas-Community icon indicating copy to clipboard operation
Christmas-Community copied to clipboard

Private Pledges

Open APT256 opened this issue 1 year ago • 8 comments

My family draws names for Christmas. Can you add an option for everyone listed to be able to randomly provided another, defined, user?

APT256 avatar Sep 28 '24 14:09 APT256

This introduces two types of complexity:

  1. It would complicate the code to add the feature. This makes it harder to refactor the app or add more features touching the same systems.
  2. It would complicate the UX and make the app harder to admin.

I think it's best to do the randomization outside of Christmas Community. You can use the app for wishlists, but use something external to tell everyone whose wishlist they should get things from. I do see how it would kind of give away that a person didn't draw you if you see that they pledged something on someone else's wishlist. How about a private pledges feature? So you wouldn't be able to see who is pledging items on each wishlist.

Wingysam avatar Sep 28 '24 15:09 Wingysam

This introduces two types of complexity:

  1. It would complicate the code to add the feature. This makes it harder to refactor the app or add more features touching the same systems.

  2. It would complicate the UX and make the app harder to admin.

I think it's best to do the randomization outside of Christmas Community. You can use the app for wishlists, but use something external to tell everyone whose wishlist they should get things from. I do see how it would kind of give away that a person didn't draw you if you see that they pledged something on someone else's wishlist. How about a private pledges feature? So you wouldn't be able to see who is pledging items on each wishlist.

Interesting... I would be willing to give a try.

APT256 avatar Sep 28 '24 19:09 APT256

Private pledges should be fairly simple. Just add a flag to src/config/index.ts then don't expose the user who pledged the item here:

https://github.com/Wingysam/Christmas-Community/blob/c0c6479a09c43501015e5f1cfb8d5897b7452075/src/views/wishlist.pug#L144-L148

Wingysam avatar Sep 28 '24 19:09 Wingysam

Unfortunately, since I installed it this via the Unraid App Store, I do not have access to the composer file. Any chance that you would consider putting your own template out on the Unraid App Store? If I get some time, I will attempt to build my own. v/rJonOn Sep 28, 2024, at 2:33 PM, Wingy @.***> wrote: Private pledges should be fairly simple. Just add a flag to src/config/index.ts then don't expose the user who pledged the item here: https://github.com/Wingysam/Christmas-Community/blob/c0c6479a09c43501015e5f1cfb8d5897b7452075/src/views/wishlist.pug#L144-L148

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

APT256 avatar Sep 28 '24 19:09 APT256

Okay, I'll look at implementing the feature and see if I can make my own Unraid template. Do you know where the documentation for Unraid template-making is?

Wingysam avatar Sep 28 '24 19:09 Wingysam

I believe this is a good starting point: https://unraid.net/community/apps/p2?r=1v/rJonOn Sep 28, 2024, at 2:54 PM, Wingy @.***> wrote: Okay, I'll look at implementing the feature and see if I can make my own Unraid template. Do you know where the documentation for Unraid template-making is?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

APT256 avatar Sep 28 '24 19:09 APT256

If you need help testing the Unraid app (if you get a chance to publish it), I would be more than happy to help!v/rJonOn Sep 28, 2024, at 2:54 PM, Wingy @.***> wrote: Okay, I'll look at implementing the feature and see if I can make my own Unraid template. Do you know where the documentation for Unraid template-making is?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

APT256 avatar Sep 28 '24 19:09 APT256

With my time constraints I don't think building my own Unraid app is the right thing to prioritize right now. I'd be happy to merge a PR adding the private pledges feature though!

Wingysam avatar Dec 30 '24 00:12 Wingysam