Wind

Results 163 comments of Wind

I think this issue can be closed :-)

Hi, thanks for your contribution, I have some throught on it. Refer to your `clippy` error, I wonder what's your rustc version? Maybe it's not up to date?

I think it's linux specific thing, and it's relative to these sys call after looks into `fish` implementation: 1. https://man7.org/linux/man-pages/man2/getpgrp.2.html 2. https://man7.org/linux/man-pages/man3/tcsetpgrp.3.html

Windows doesn't have the scenario like this, so the pr shouldn't affect anything on windows

> I thought this was more for the tmux usage Yeah, and I've checked `ion`, it doesn't set title as well

Hi, you can try the following to make nu friendly to light background: 1. in `$nu.config-path` file, change the relative color config value to `$light_theme` (https://github.com/nushell/nushell/blob/main/docs/sample_config/default_config.nu#L240) 2. Using [vivid](https://www.nushell.sh/book/coloring_and_theming.html#ls-colors-colors-for-the-ls-command) to...

@wavebeem Thanks for your suggestion, the light theme relative doc is updated here: https://www.nushell.sh/book/coloring_and_theming.html#working-on-light-background-terminal

For now I'm just end up with something like this: ```rust struct InnerStore { folder_path: PathBuf, index: HashMap, useless_cmd: usize, } pub struct KvStore { inner: Arc, } ``` In...