Wind

Results 163 comments of Wind

Sure. Sorry that I've changed to `command: closure` locally, but forget to create a pr. > But changing that line to command: closure also fails, with "cannot convert closure to...

The error message is raised from ucp. And it fall into the following code: https://github.com/nushell/nushell/blob/44be445b579b001c9ba2fd93dbccd44e895a2d65/crates/nu-command/src/filesystem/ucp.rs#L275-L278 @dmatos2012 Sorry for pinging, do you know how it happened?

> Mhh yeah, if the behavior pre https://github.com/nushell/nushell/pull/12625 also effictively collected the particular directory, then sorting one directory is probably fine. Ah, @sholderbach you make a good point! I think...

> I think they need to clear the output register at least (equivalent of return empty) Thank you for your input @devyn ! I think I get the idea. Although...

I don't think so, I checked the generated IR, it seems fine to me

> so there is no need to worry about accidentally overwriting $env.LAST_EXIT_CODE when running an external command in your prompt command I'm not sure if I get the idea behind...

To be honest, I'm not really sure about it. We have many built-in variables, I'm afraid it might make nushell more complicated, `LAST_EXIT_CODE` is good enough to me

Thanks for proposing the PR. I think it's too old and still a draft PR. I'm going to close it. If you think the change is still necessary, feel free...

Closing the issue because the question is answered.

Thanks for proposing the PR. I think it's too old and still a draft PR. I'm going to close it. If you think the change is still necessary, feel free...