winmerge icon indicating copy to clipboard operation
winmerge copied to clipboard

maximised tabs' clickable part dont extend to screen edge

Open tsehygit opened this issue 7 months ago • 3 comments

similar to #2520 but for tabs' clickable part. clicking the edge dont switch to that tab. trying to move tabs remove window from maximised size and drags it instead.

tsehygit avatar Apr 17 '25 18:04 tsehygit

You’re probably referring to clicking on the very top edge of the title bar — is that correct?

Since double-clicking the top edge of the title bar exits maximized mode, this behavior has some merit. However, browsers like Edge and Firefox do switch tabs when clicking the top edge of the title bar, so perhaps WinMerge should follow that behavior too...

sdottaka avatar Apr 17 '25 22:04 sdottaka

You’re probably referring to clicking on the very top edge of the title bar — is that correct?

exactly.

tsehygit avatar Apr 18 '25 14:04 tsehygit

@tsehygit @sdottaka

I made a PR which maybe considered as a temporary solution for this issue.

Since double-clicking the top edge of the title bar exits maximized mode, this behavior has some merit.

Since you said so, I didn't intercept this behavior. With this PR, the new behavior will be both selecting the tab and exitting maximized mode.

However, browsers like Edge and Firefox do switch tabs when clicking the top edge of the title bar, so perhaps WinMerge should follow that behavior too...

I've noticed that browsers render the tab button at maximum height when in maximized mode. If we aim to follow their behavior, I think we should apply the same tab button rendering mechanism in WinMerge. I actually also tried rendering the tab button at maximum height, but it didn’t look great. To improve the appearance, we should render the bottom border of the tab button the same way browsers do.

Anyway, my PR isn't complete yet. Please test it and provide some suggestions to help me finish it.

anthonyleestark avatar Jul 01 '25 09:07 anthonyleestark

This issue has been resolved by PR #2828.

sdottaka avatar Jul 22 '25 23:07 sdottaka