eyesome icon indicating copy to clipboard operation
eyesome copied to clipboard

Brightness/Gamma doesn't work

Open audio101 opened this issue 1 year ago • 30 comments

Changing settings do not have any effect in altering brightness/gamma.

[OS: Manjaro XFCE]

audio101 avatar Dec 09 '24 05:12 audio101

Changing settings do not have any effect in altering brightness/gamma.

[OS: Manjaro XFCE]

When you use xrandr from the command line does it successfully change brightness and gamma?

pippim avatar Dec 09 '24 05:12 pippim

Hello,

Can you give me a specific command or commands to test?

audio101 avatar Dec 09 '24 06:12 audio101

Hello,

Can you give me a specific command or commands to test?

Sorry for the delay. The first command would be xrandr | grep " connected". Note if you are using Wayland then xrandr will not work by default.

pippim avatar Dec 11 '24 23:12 pippim

xrandr | grep " connected" HDMI-1 connected 1280x1024+0+0 (normal left inverted right x axis y axis) 380mm x 300mm

audio101 avatar Dec 12 '24 03:12 audio101

@audio101 Please edit the configuration. Click the "Sun times" tab. Are the sunrise / sunset times correct? Click the "Monitor 1" tab. Does it contain the name "HDMI-1"? What are the Nighttime Brightness / Red / Green / Blue values? Save / Cancel the configuration. At the main screen, click the "Daytime" and "Nighttime" buttons. Do you see changes for five seconds?

pippim avatar Dec 13 '24 22:12 pippim

eyesome_Manjaro_1

eyesome_Manjaro

eyesome_Manjaro_2

Applying settings - "Daytime" / "Nighttime" / "Override" don't do anything.

audio101 avatar Dec 17 '24 01:12 audio101

What settings are you using for Daytime and Nighttime. Can you key them into xrandr in the command line and get expected results?

On Mon, Dec 16, 2024, 6:13 p.m. audio101 @.***> wrote:

eyesome_Manjaro.jpg (view on web) https://github.com/user-attachments/assets/2140f446-1252-4cfe-afc7-25c2f4002ac1

eyesome_Manjaro_2.jpg (view on web) https://github.com/user-attachments/assets/c283d4bb-4f49-416f-a674-d024f9d3e6c3

Changing settings - "Daytime" / "Nighttime" / "Override" buttons don't do anything.

— Reply to this email directly, view it on GitHub https://github.com/WinEunuuchs2Unix/eyesome/issues/14#issuecomment-2547291379, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWCZRNZNM7BJLJMVZZ5TCXT2F53CNAVCNFSM6AAAAABTIBJXH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBXGI4TCMZXHE . You are receiving this because you commented.Message ID: @.***>

pippim avatar Dec 17 '24 15:12 pippim

Any chance you can just test it yourself using Manjaro XFCE with VirtualBox?

https://download.manjaro.org/xfce/24.2.1/manjaro-xfce-24.2.1-241216-linux612.iso

audio101 avatar Dec 17 '24 22:12 audio101

@audio101 Sorry I don't have time to learn new Desktops or OS. Software development on Ubuntu takes all my time. It could be that VirtualBox itself is preventing changes to the monitors brightness and gamma. Eyesome is designed to run on the operating system itself, not in a sandbox.

EDIT: I did a quick search and it confirms my thought: https://forums.virtualbox.org/viewtopic.php?t=18188

pippim avatar Dec 19 '24 01:12 pippim

Hello, just to clarify, I am running Manjaro XFCE fully installed on a real hardware/desktop PC, not via Virtualbox. I was merely suggesting if you could try testing eyesome on your end yourself virtually instead (or else via a full installation of Manjaro XFCE on real hardware), since despite trying it's 100% not working at all on my end as it should be doing. Thanks.

audio101 avatar Dec 19 '24 02:12 audio101

@audio101 Sorry I misunderstood the virtualbox issue. I see now your monitor type is set to "Hardware" It should be set to "Software" for xrandr to work properly. Try changing this, saving and testing Daytime / Nighttime buttons.

pippim avatar Dec 19 '24 02:12 pippim

Hello, thanks I appreciate that, yes there was a misunderstanding there on your part, no worries.

Anyway I've mainly been using Gammy, which is a great app that uses a percentage slider for both brightness and temperature. But it has a bug where you have to load it again as it exits from the tray after closing it on startup, but is now defunct, so I want to use eyesome now instead.

I wanted to suggest instead of the confusing input values "1.00" etc, to change that to a percentage value instead. Sliders would be awesome too, but if you can't code that in then for now, I'd change it to % input values instead if you can.

As for "Software" setting, that doesn't make any difference to changing the darkness of the monitor, as per changing the values in the settings.

Many thanks for your development on the app and hope to get it working soon.

audio101 avatar Dec 19 '24 03:12 audio101

Brightness slider was already a long term plan and is used for the color temperature already:

eyesome color converter

Try entering this in the command line:

xrandr --output HDMI-1 --birightness 0.5

Then to set it back to 100% use:

xrandr --output HDMI-1 --birightness 1.0

This is the first step to see if xrandr is working properly on your system.

pippim avatar Dec 19 '24 13:12 pippim

Those commands work & monitor brightness changes. (Btw, typo for the word: "brightness")

audio101 avatar Dec 20 '24 05:12 audio101

@audio101 Now that we know xrandr is working, lets see if eyesome has error messages:

journalctl -b-0 | grep -i eyesome

Status messages will normally be displayed. Are there any warning or error messages? (Sorry for typo in last comment)

pippim avatar Dec 20 '24 11:12 pippim

journalctl -b-0 | grep -i eyesome

audio101 avatar Dec 20 '24 12:12 audio101

@audio101 eyesome has only been tested with suspend not with hibernate. There are a few error messages reported that I will need to review. I will desk-check the code this weekend. I will also need to research how hibernate differs from suspend. BTW, using copy & paste terminal output instead of screenshot allows me to copy lines of text to my system. A screenshot requires retyping the output which can lead to typos - which you already noticed I can make :). Thanks for the output that gives me clues where to start looking!

pippim avatar Dec 20 '24 13:12 pippim

@audio101 Looking at your journalctl -b-0... the screenshot is missing date and time. It also only shows signing on and system hibernating / waking up.

As a different test can you run sudo eyesome-cfg.sh. Click the "Daytime" button and click "Quit" button. Wait a bit and repeat but this time using the "Nighttime" button.

Now type journalctl -xe | grep eyesome. Output (copy and pasted) should look like this:

Dec 21 08:53:27 alien sudo[27364]:     rick : TTY=pts/18 ; PWD=/home/rick ; USER=root ; COMMAND=/usr/local/bin/eyesome-cfg.sh &
Dec 21 08:53:33 alien eyesome[27720]: Wakeup: Called from eyesome-cfg.sh.
Dec 21 08:54:12 alien sudo[30377]:     rick : TTY=pts/18 ; PWD=/home/rick ; USER=root ; COMMAND=/usr/local/bin/eyesome-cfg.sh &
Dec 21 08:54:18 alien eyesome[30737]: Wakeup: Called from eyesome-cfg.sh.

At 53 minutes and 27 seconds above you see the "Daytime" button test. At 54 minutes and 18 seconds above you see the "Nighttime" button test.

Please copy and paste (no screenshot) your journalctl -xe | grep eyesome results of the Daytime / Nightie button tests. Highlight the output lines and click the GitHub code icon < > in the icon banner above where you are writing your GitHub message.

Thanks in advance.

pippim avatar Dec 21 '24 16:12 pippim

@audio101 Looking at your screenshot, the kill command is failing. The command kills the sleep command and forces eyesome.sh to wake and set the brightness and gamma. What is your bash --version? On my system it is 4.3.8 and any earlier version may not work.

Please run these tests at the command line:

$ EyesomeDaemon=/usr/local/bin/eyesome.sh

$ ProcessTree=$(pstree -g -p | grep "${EyesomeDaemon##*/}" | grep sleep)

$ echo $ProcessTree
|-cron(1444,1444)---cron(1457,1444)---sh(1469,1469)---eyesome.sh(1477,1469)---sleep(20670,1469)

$ pID=${ProcessTree##*sleep(}

$ echo $pID
20670,1469)

$ pID=${pID%,*}

$ echo $pID
20670

The leading $ is not entered. All $ in the middle of the command are necessary to identify bash variables.

I'd be happy to make changes to support Arch / Manjaro as long as it doesn't break Ubuntu support which the eyesome was developed for seven years ago and enhanced a few times since then.

pippim avatar Dec 22 '24 16:12 pippim

The commands above entered ok, except:

echo $ProcessTree |-cron(1444,1444)---cron(1457,1444)---sh(1469,1469)---eyesome.sh(1477,1469)---sleep(20670,1469) |-crond(957,957)---crond(961,957)---eyesome.sh(962,962)---sleep(15075,962) bash: syntax error near unexpected token `|'

echo $pID 20670,1469) 15075,962) bash: syntax error near unexpected token `)'

echo $pID 20670 15075,962) bash: 20670: command not found

bash --version GNU bash, version 5.2.37(1)-release (x86_64-pc-linux-gnu)

audio101 avatar Dec 25 '24 09:12 audio101

[linux@streacom ~]$ journalctl -xe | grep eyesome Dec 25 16:22:49 streacom CROND[962]: (root) CMD (/usr/local/bin/eyesome.sh) Dec 25 16:22:49 streacom eyesome[962]: Daemon: Launching /usr/local/bin/eyesome-dbus.sh daemon Dec 25 16:22:49 streacom eyesome[982]: DBUS: Starting DBUS-Monitor using type=method_call, interface=org.freedesktop.ColorManager, path=/org/freedesktop/ColorManager, member=FindDeviceByProperty Dec 25 16:23:09 streacom eyesome[962]: Daemon: Waited 20 seconds for linux to login. Dec 25 16:23:30 streacom eyesome[962]: Daemon: Login: Slept 2 seconds x 5 times. Dec 25 20:26:45 streacom sudo[17713]: linux : TTY=pts/0 ; PWD=/home/linux ; USER=root ; COMMAND=/usr/local/bin/eyesome-cfg.sh Dec 25 20:26:55 streacom eyesome[17806]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:27:08 streacom eyesome[17887]: Wakeup: Called from eyesome-cfg.sh. [linux@streacom ~]$

[linux@streacom ~]$ journalctl -xe | grep eyesome Dec 25 16:22:49 streacom CROND[962]: (root) CMD (/usr/local/bin/eyesome.sh) Dec 25 16:22:49 streacom eyesome[962]: Daemon: Launching /usr/local/bin/eyesome-dbus.sh daemon Dec 25 16:22:49 streacom eyesome[982]: DBUS: Starting DBUS-Monitor using type=method_call, interface=org.freedesktop.ColorManager, path=/org/freedesktop/ColorManager, member=FindDeviceByProperty Dec 25 16:23:09 streacom eyesome[962]: Daemon: Waited 20 seconds for linux to login. Dec 25 16:23:30 streacom eyesome[962]: Daemon: Login: Slept 2 seconds x 5 times. Dec 25 20:26:45 streacom sudo[17713]: linux : TTY=pts/0 ; PWD=/home/linux ; USER=root ; COMMAND=/usr/local/bin/eyesome-cfg.sh Dec 25 20:26:55 streacom eyesome[17806]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:27:08 streacom eyesome[17887]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:30:42 streacom sudo[18022]: linux : TTY=pts/0 ; PWD=/home/linux ; USER=root ; COMMAND=/usr/local/bin/eyesome-cfg.sh Dec 25 20:30:48 streacom eyesome[18102]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:31:00 streacom eyesome[18214]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:31:15 streacom eyesome[18325]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:31:31 streacom eyesome[18419]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:31:34 streacom eyesome[18452]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:33:22 streacom sudo[18594]: linux : TTY=pts/0 ; PWD=/home/linux ; USER=root ; COMMAND=/usr/local/bin/eyesome-cfg.sh Dec 25 20:33:38 streacom eyesome[18708]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:33:44 streacom eyesome[18782]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:33:53 streacom eyesome[18868]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:33:57 streacom eyesome[18934]: Wakeup: Called from eyesome-cfg.sh. Dec 25 20:34:08 streacom eyesome[19025]: Wakeup: Called from eyesome-cfg.sh.

audio101 avatar Dec 25 '24 09:12 audio101

@audio101 Only type what is behind the $ prompt and press Enter. The next line that appears is the output of the command that we need to see. Do not type in the line after the $ as input into your system. That is the reason for he bash errors; my output example is being typed into your system as an input command. E.G.:

$ |-cron(1444,1444)---cron(1457,1444)---sh(1469,1469)---eyesome.sh(1477,1469)---sleep(20670,1469)

You typed in | cron... as a command at the $ command prompt and it is an invalid command.

Please repeat the test only entering what is behind the $:

EyesomeDaemon=/usr/local/bin/eyesome.sh
ProcessTree=$(pstree -g -p | grep "${EyesomeDaemon##*/}" | grep sleep)
echo $ProcessTree
pID=${ProcessTree##*sleep(}
echo $pID
pID=${pID%,*}
echo $pID

The above is all that is literally entered after the $ prompts.

Thanks.

pippim avatar Dec 25 '24 21:12 pippim

EyesomeDaemon=/usr/local/bin/eyesome.sh ProcessTree=$(pstree -g -p | grep "${EyesomeDaemon##*/}" | grep sleep) echo $ProcessTree pID=${ProcessTree##sleep(} echo $pID pID=${pID%,} echo $pID |-crond(928,928)---crond(932,928)---eyesome.sh(933,933)---sleep(1917,933) 1917,933) 1917

audio101 avatar Dec 31 '24 00:12 audio101

@audio101 Thank you for the test results. Everything is successful with no errors reported. Can you run journalctl -b-0 | grep eyesome one more time. I'd like to see if the error messages 2 weeks ago are gone now.

pippim avatar Dec 31 '24 03:12 pippim

[linux@streacom ~]$ journalctl -b-0 | grep eyesome Dec 31 10:48:07 streacom CROND[933]: (root) CMD (/usr/local/bin/eyesome.sh) Dec 31 10:48:07 streacom eyesome[933]: Daemon: Launching /usr/local/bin/eyesome-dbus.sh daemon Dec 31 10:48:07 streacom eyesome[953]: DBUS: Starting DBUS-Monitor using type=method_call, interface=org.freedesktop.ColorManager, path=/org/freedesktop/ColorManager, member=FindDeviceByProperty Dec 31 10:50:29 streacom eyesome[933]: Daemon: Waited 54 seconds for linux to login. Dec 31 10:50:50 streacom eyesome[933]: Daemon: Login: Slept 2 seconds x 5 times. [linux@streacom ~]$

audio101 avatar Dec 31 '24 05:12 audio101

@audio101 That test looks fine. Can you repeat the test after clicking "Daytime" and "Nighttime" buttons in sudo eyesome-cfg.sh please?

pippim avatar Dec 31 '24 12:12 pippim

[linux@streacom ~]$ journalctl -b-0 | grep eyesome Dec 31 10:48:07 streacom CROND[933]: (root) CMD (/usr/local/bin/eyesome.sh) Dec 31 10:48:07 streacom eyesome[933]: Daemon: Launching /usr/local/bin/eyesome-dbus.sh daemon Dec 31 10:48:07 streacom eyesome[953]: DBUS: Starting DBUS-Monitor using type=method_call, interface=org.freedesktop.ColorManager, path=/org/freedesktop/ColorManager, member=FindDeviceByProperty Dec 31 10:50:29 streacom eyesome[933]: Daemon: Waited 54 seconds for linux to login. Dec 31 10:50:50 streacom eyesome[933]: Daemon: Login: Slept 2 seconds x 5 times. Dec 31 23:15:22 streacom sudo[128188]: linux : TTY=pts/0 ; PWD=/home/linux ; USER=root ; COMMAND=/usr/local/bin/eyesome-cfg.sh Dec 31 23:15:46 streacom eyesome[128356]: Wakeup: Called from eyesome-cfg.sh. Dec 31 23:15:59 streacom eyesome[128543]: Wakeup: Called from eyesome-cfg.sh. [linux@streacom ~]$

audio101 avatar Dec 31 '24 12:12 audio101

@audio101 I was hoping to see error messages appear like when your system was suspending. At least an error message gives me somewhere to focus. Can you give me some details about your operating system? Maybe that will give me some clues. Also keep eyesome running when you suspend / resume your system and periodically check journalctl -b-0 | grep eyesome output to report any errors.

Thanks.

pippim avatar Jan 01 '25 13:01 pippim

[linux@streacom ~]$ journalctl -b-0 | grep eyesom Jan 10 08:17:24 streacom CROND[999]: (root) CMD (/usr/local/bin/eyesome.sh) Jan 10 08:17:24 streacom eyesome[999]: Daemon: Launching /usr/local/bin/eyesome-dbus.sh daemon Jan 10 08:17:24 streacom eyesome[1013]: DBUS: Starting DBUS-Monitor using type=method_call, interface=org.freedesktop.ColorManager, path=/org/freedesktop/ColorManager, member=FindDeviceByProperty Jan 10 08:17:34 streacom eyesome[999]: Daemon: Waited 10 seconds for linux to login. Jan 10 08:19:42 streacom eyesome[999]: Daemon: Login: Slept 2 seconds x 5 times. [linux@streacom ~]$

audio101 avatar Jan 10 '25 11:01 audio101

@audio101 Unfortunately the last log you posted is normal behavior. I need an error message to focus on.

I have a new idea. Continue to use journalctl without the grep eyesome. Then page up/down through the log to where it says "Waking up eyesome" and look for an error message from another program immediately after.

pippim avatar Jan 10 '25 13:01 pippim