Will Sewell comments

Results 20 comments of


                                            Will Sewell

Enable and enforce goroutine leak checks in tests

I had a look into `./plugin/sampling/strategystore/adaptive/`. One challenge is the high default `Processor.followerRefreshInterval` (20s) which causes the `runUpdateProbabilitiesLoop` to hang long enough that either Close() needs to block a long...

Enable and enforce goroutine leak checks in tests

Solved in a different way: https://github.com/jaegertracing/jaeger/pull/5310/commits/dfe7adc7fd34389e2e507d9512eb64b5e19048f7

Add `benchmarkWith`

Sorry - I must have missed this when you originally opened it! I feel like it is a bit odd that this would only return the first result, and makes...

Allow cluster to be set when creating new client

The doesn't exist becuase the library was built before Pusher released support for multiple clusters and this library has not been updated to support it. Having it as a method...

Add `authenticate_user`, `send_to_user` and `terminate_user_connections` to the client

👋 thanks for contributing to this repository. I'm afraid due to life circumstances I just haven't had the bandwidth to review PRs, and stay up to date with Rust in...

Write integration tests

Will need to implement a WebSocket client.

Various improvements

👋 thanks for contributing to this repository. I'm afraid due to life circumstances I just haven't had the bandwidth to review PRs, and stay up to date with Rust in...

Return error as `Error` rather than `String` type?

Yes I think this would be nicer :)

"Missing C library: pq" on Windows 7

Thank you. I will try that out.

Refresh the OCaml version from 4.14 to 5.2

Got a fair bit of variance in the results, but even taking the mean over 5 runs is still significantly faster than the previous version :) https://github.com/WillSewell/gc-latency-experiment/commit/f67121ec8a741201414c76d5ba85f9304c774acc