swayfx icon indicating copy to clipboard operation
swayfx copied to clipboard

m1 NixOS asahi - Borders are a bit messed up

Open aspauldingcode opened this issue 1 year ago • 2 comments

on NixOS asahi, Blur is a bit broken graphically, and swayfx borders aren't rendered correctly.

See comparison of swayfx window border rounded vs waybar rounded border radius;

Screenshot 2024-08-08 at 03 43 20 PM

swayfx version 0.4 (based on sway 1.9.0) NixOS 24.05

aspauldingcode avatar Aug 08 '24 15:08 aspauldingcode

I've additionally enabled asahi experimental gpu driver, so rendering these things should be possible. Maybe its an anti-aliasing issue?

aspauldingcode avatar Aug 08 '24 15:08 aspauldingcode

should be fixed once we use the scenefx border impl in https://github.com/wlrfx/scenefx/pull/59

WillPower3309 avatar Oct 15 '24 03:10 WillPower3309

Q: is this still present? We switched to the scenefx border impl in #367

WillPower3309 avatar May 06 '25 22:05 WillPower3309

Yes, the issue is still present. However, it depends on if I’m updated to using what you are using. What version is this fixed on? I’m using nixos on m1. I can check

aspauldingcode avatar May 06 '25 23:05 aspauldingcode

By the way, the issue I have now is a bit different. Sometimes, window corners have black backgrounds. I can’t totally tell about the resolution. Seems better.

aspauldingcode avatar May 06 '25 23:05 aspauldingcode

Hmm, seems like a blending issue. Do you have any way to reproduce the black backgrounds?

WillPower3309 avatar May 07 '25 01:05 WillPower3309

I will give a much more helpful reply when I’m at my machine :-)

aspauldingcode avatar May 07 '25 02:05 aspauldingcode

Okii Dokiee. I'm on nixos 6.13.5-asahi on 2020 M1 Macbook Air. I've got NixOS flakes, with

sway --version
swayfx version 0.5 (based on sway 1.10.1)

Image

This is what it looks like today. The top is waybar, the bottom is swayfx on Alacritty window.

Also, if I use my toggle-gaps shell script, it will show a black bar. I think that's probably just my second alias waybar now that I think about it:

Image

It goes away after moving mouse over it.

*EDIT: yeah definitely just a black line caused by Waybar. Not swayfx.

aspauldingcode avatar May 10 '25 14:05 aspauldingcode

Are you using anti-aliasing at all?

aspauldingcode avatar May 10 '25 14:05 aspauldingcode

Mavcbooks have retina display. Everything is scaled up 2x, so that elements on the screen would be extra crisp.

I've set the scaling factor of sway to 2x, because at native every element is too small to see.

Is swayfx not accounting for scaling?

aspauldingcode avatar May 10 '25 21:05 aspauldingcode

Mavcbooks have retina display. Everything is scaled up 2x, so that elements on the screen would be extra crisp.

I've set the scaling factor of sway to 2x, because at native every element is too small to see.

Is swayfx not accounting for scaling?

Swayfx accounts for scaling. From discussions on discord it seems this is either a GL precision issue (in scenefx), or a potential bleeding edge mesa issue. Some users fixed this by using an earlier mesa version, but it's likely otherwise a floating point precision issue in scenefx

WillPower3309 avatar May 12 '25 17:05 WillPower3309

Im getting a similar issue on Arch - It only started in the last few days after an update (I am not sure of what specifically).

Image

tmilner avatar May 30 '25 16:05 tmilner

Image

the top-left border looks a bit weird for me too, i'm using arch linux on a thinkpad t480 with normal scaling and 1920x1080

FelipeFMA avatar Jun 29 '25 15:06 FelipeFMA

Image

the top-left border looks a bit weird for me too, i'm using arch linux on a thinkpad t480 with normal scaling and 1920x1080

what version are you running? Long story short this was a gles2 issue that was resolved by updating our shaders to support gles3. The newest version of swayfx shouldn't have this issue

WillPower3309 avatar Jun 30 '25 02:06 WillPower3309

These are likely fixed on asahi macs as well, can anyone confirm if this is still present in the most recent release? I don't have the hardware to confirm

WillPower3309 avatar Jun 30 '25 02:06 WillPower3309

Image the top-left border looks a bit weird for me too, i'm using arch linux on a thinkpad t480 with normal scaling and 1920x1080

what version are you running? Long story short this was a gles2 issue that was resolved by updating our shaders to support gles3. The newest version of swayfx shouldn't have this issue

yeah, the version on the cachyos repos is old. installing the one on AUR solves my issue.

FelipeFMA avatar Jun 30 '25 14:06 FelipeFMA

This should be fixed in the most recent release, please re open if that isn't the case! Thanks everyone

WillPower3309 avatar Jun 30 '25 14:06 WillPower3309

This now looks nearly perfect. There is a single missing pixel only showing on the top-left corner with my config.

aspauldingcode avatar Sep 09 '25 19:09 aspauldingcode

This now looks nearly perfect. There is a single missing pixel only showing on the top-left corner with my config.

Awesome! This is actually a known issue, will be fixed for next release

WillPower3309 avatar Sep 10 '25 14:09 WillPower3309