Will Lillis

Results 113 comments of Will Lillis

Was away from my computer for most of the weekend but I was able to work on this a bit. I'm going to spend some more time writing tests and...

I was kinda curious why this error wasn't showing up even with `enable_build_on_save` turned on. It looks like the issue is how the error is reported by the zig compiler....

> sorry for not reviewing it sooner (lot on the plate) No worries, y'all have been doing a ton of cool stuff with the project lately! > I'd like it...

Here's a first pass on your feedback. I now have the test numbers printing out (with a set width of 3 characters) by default. ~~I ran into some issues maintaining...

> what happened to --list? would it just be better to keep the numbers visible by default? Yeah I had removed `--list` so that the numbers would just print by...

> I do think we should use 1. instead of 1:, it's a little cleaner, and we should also start indexing at 1 since a "zeroth" test looks funky. Sounds...

I did a little testing and found the code printing the error (Line 171 of `cli/src/generate/parse_grammar.rs`): https://github.com/tree-sitter/tree-sitter/blob/f8c41f74f8c1bda0fdd82c07357ae601b6b2f62e/cli/src/generate/parse_grammar.rs#L154-L177 The comment suggests that the unicode flag is expected to be `u`, instead...

Hey @gilbertfrancois! You should be able to set asm-lsp to work just with z80-related stuff by specifying it in your config file, `.asm-lsp.toml`. This can be placed at a given...

Still haven't found a great reference for the opcodes, but we should be able to add partial MASM support by adding the directives specified here: https://learn.microsoft.com/en-us/cpp/assembler/masm/directives-reference?view=msvc-170