Error in helpful-callable for facemenu-menu

[c256]

Recent discussion on emacs-devel reminded me about the facemenu commands, and I wanted to look at the documentation for them. Using helpful to look at facemenu-menu gives me a helpful buffer with only the top line:

facemenu-menu is a function defined in facemenu.el.gz.

[CURSOR]

and the backtrace

Debugger entered--Lisp error: (wrong-type-argument sequencep t)
  mapconcat(identity (t) " ")
  s-join(" " (t))
  helpful--signature(facemenu-menu)
  helpful-update()
  helpful-callable(facemenu-menu)
  funcall-interactively(helpful-callable facemenu-menu)
  call-interactively(helpful-callable nil nil)
  command-execute(helpful-callable)

As near as I can tell, this stems from the following idiom: (defalias 'facemenu-menu facemenu-menu)

...which makes a non-callable show up in the completion list for helpful-callable; I see similar things with, for example, ctl-x-5-prefix, which uses a similar idiom. I'm going to bring up the use of defalias for non-functions on emacs-devel, fwiw.

[bestlem]

Add to that yes-or-no-p when aliased to y-or-n-p by

(fset 'yes-or-no-p 'y-or-n-p)