elisp-refs icon indicating copy to clipboard operation
elisp-refs copied to clipboard

Use magit sections to display results

Open tarsius opened this issue 4 years ago • 6 comments

By doing so we can get rid of some code while gaining features. For example, files can now be collapsed globally using "M-1" or individually using "TAB".

I first brought this up in #21, but back then magit-section was not available as a stand-alone package yet. Now that it is available, using it seems like a clear win.

This pull-request also contains the cleanup commits from my earlier outstanding pull-request #26.

tarsius avatar Jul 10 '20 12:07 tarsius

Coverage Status

Coverage decreased (-41.9%) to 33.505% when pulling 1b5529c2e362db46c609df451592137bef08061c on tarsiiformes:magit-sections into b3634a4567c655a1cda51b217629849cba0ac6a7 on Wilfred:master.

coveralls avatar Jul 10 '20 12:07 coveralls

Playing with this, I think there's a bug with magit-insert-section. Its expansion includes calls to if-let, but that doesn't work if subr-x hasn't been required.

Wilfred avatar Aug 16 '20 00:08 Wilfred

I've just pushed a fix for that.

tarsius avatar Aug 16 '20 10:08 tarsius

... and rebased this pr.

tarsius avatar Aug 17 '20 13:08 tarsius

magit-section is now available as a stand-alone package on NonGNU Elpa and on Melpa.

Since that is the case now, I would argue that this should be merged. What do you think?

tarsius avatar Sep 07 '21 20:09 tarsius

Ah reading the above again I see that it was already available from Melpa when I opened this. Well... for what it is worth, now it is available from NonGNU Elpa too! :P

tarsius avatar Sep 07 '21 20:09 tarsius