deadgrep icon indicating copy to clipboard operation
deadgrep copied to clipboard

Add deadgrep-file-type-alist to allow user-defined easily toggle-able set of types

Open gvol opened this issue 4 years ago • 9 comments

As usual when writing elisp, I mostly stopped once I got it working, so feel free to make me fix a few things that don't match your code style or quality.

In particular, I wasn't sure if all should be part of the introduced alist or not—I could go either way. I left it as being special, but I'm happy to change it. I'm also not sure what order the buttons should be in. I kind of think they type and glob should be last since they are the most ad-hoc, but I imagine that I will set deadgrep-file-type-alist by project, so it might also be nice to have the "global" one be in more stable positions.

Also, I'm happy to add more tests if you think they are warranted. I couldn't find any other tests about creating or interacting buttons for example.

I do have papers signed with the FSF in case that's a concern.

gvol avatar Jan 14 '21 05:01 gvol

Sorry, I hate to bug you, @Wilfred, but do you know what I should do to get the tests passing? I've never actually used Travis before and Cask only a little.

gvol avatar Jan 16 '21 17:01 gvol

I've moved the tests from Travis to GitHub actions, and they should now be passing :)

Wilfred avatar Jan 28 '21 08:01 Wilfred

Okay, I rebased on master. Hopefully, they'll pass now.

gvol avatar Jan 29 '21 19:01 gvol

Sorry it took me so long to get back to this. I rebased on master again and updated my tests for changes on master.

gvol avatar Feb 11 '21 03:02 gvol

Thoughts, @Wilfred?

gvol avatar Mar 15 '21 23:03 gvol

I've been using this for a while now, and I find it extremely useful. Is there anything you would like me to do?

gvol avatar Sep 15 '21 23:09 gvol

Hi - just wondering if there was any chance of this being merged? deadgrep's really useful, but the company I work for uses '.inc' for a lot of their Makefiles - it would be really useful to be able to add a type which searched those as well as normal Makefile names. :-)

arafel avatar Aug 16 '23 10:08 arafel

Here's what the results might look like, just as an example: Screen Shot 2023-08-16 at 08 13 13

gvol avatar Aug 16 '23 14:08 gvol

Since you recently merged #138, maybe I'll gently poke you about this one as well. ❤️

gvol avatar Sep 10 '23 04:09 gvol