Wilfred Hughes
Wilfred Hughes
Possibly related: https://github.com/rust-lang/rust/issues/95926 Maybe musl builds should use rust 1.61 to avoid that issue.
https://github.com/rust-lang/rust/issues/74757 also shows a very similar backtrace.
What's really bizarre here is that the musl builds are dynamically linked. This is wrong, and differs from the rust default (musl targets are statically linked). ``` $ ldd difft...
Thanks, I'll try that. I don't understand why I'm not getting static linking, rust should statically link musl builds by default I believe: ``` $ cargo new demo Created binary...
``` $ cross build --release --target x86_64-unknown-linux-musl $ ldd target/x86_64-unknown-linux-musl/release/difft statically linked $ ./target/x86_64-unknown-linux-musl/release/difft --version Difftastic 0.52.0 (6805939c6 2023-09-28) ``` I can't replicate this with `cross` locally. I'm inclined to...
I'm wondering if something is picking up an old version of cross. https://github.com/cross-rs/cross/issues/902 looks relevant.
Probably worth filing an issue on upload-rust-binary-action to see if I've missed anything.
Reproduces on CI now, fortunately: https://github.com/Wilfred/difftastic/actions/runs/6986277695/job/19011557098 (after 6051f0519bcef18d86ff043da15deac2a4274361).
How many lines are in the files, and roughly how many lines are in common (e.g. how big is a patch created by GNU diff)? You're probably hitting the scaling...
@simonmichael are you sure that's the same issue? I can't reproduce with your files. ``` $ /bin/time -v difft a.txt b.txt >/dev/null Command being timed: "difft a.txt b.txt" User time...