public encounters should be OpenSearch searchable by any (logged in) user

[naknomum]

Expected Behavior Any user can see public data in search results

Current Behavior Some users (99% sure it is those without usernames) do not have access

Tech Notes This has to do with enc.canUserAccess() which requires a username on every user. Proposed workaround/fix:

• create enc.isPublic() method which wraps the questionable logic for determining this
• modify canUserView() to short circuit at the top to return true if enc.isPublic()

[naknomum]

technical note: it would be to have two methods: isPublicOwned() and isPublicViewable(), where the viewable is based on being public-owned and also approved. (or something like this) to help make the distinction between a "public encounter" and one which can be viewed and "is public".

[holmbergius]

Resolved in release 10.5.3 by Issue #976 and related commits.