Remove TapirLink
[Plain-text summary description of the solution]
PR fixes #401
Changes
- [bullet list include any model updates]
- [new or edited functions]
- [significant changes to UX]
- [design decisions, especially if architectural patterns are new/altered]
- [can use text, screenshots, or files]
- [a callout of any ##TODO or ##FIXMEs found/created as part of the fix]
@carllelandtaylor to address your couple of questions in the code:
- TODO before merge: does some schema need updating as well? - no, we can leave the tapirlink-related column in the db. it will not be created for new wildbooks, and should not mess up existing legacy tables
MassExposeGBIF.java- i agree, this servlet should also go away, as all it does is modify tapirlink values; good call. @TanyaStere42 do you agree? i think then this would cascade to mean also altering:appadmin/admin.jsp(to remove the button) andweb.xmlto remove the servlet entries.
That seems like minimal scope creep, so I'm good with it if @carllelandtaylor is
@carllelandtaylor @naknomum Can I help drive forward this removal? This is a great set of code to get rid of.
@carllelandtaylor @naknomum Can I help drive forward this removal? This is a great set of code to get rid of.
Hey, sorry team that I didn't get back to this and haven't been active! Day job got extra busy.
You're welcome to take this over as far as I'm concerned!
@carllelandtaylor @naknomum Can I help drive forward this removal? This is a great set of code to get rid of.
Hey, sorry team that I didn't get back to this and haven't been active! Day job got extra busy.
You're welcome to take this over as far as I'm concerned!
thanks for the notice and the work toward a solution.