Wildbook icon indicating copy to clipboard operation
Wildbook copied to clipboard

Remove TapirLink

Open carllelandtaylor opened this issue 1 year ago • 5 comments

[Plain-text summary description of the solution]

PR fixes #401

Changes

  • [bullet list include any model updates]
  • [new or edited functions]
  • [significant changes to UX]
  • [design decisions, especially if architectural patterns are new/altered]
  • [can use text, screenshots, or files]
  • [a callout of any ##TODO or ##FIXMEs found/created as part of the fix]

carllelandtaylor avatar Sep 15 '24 04:09 carllelandtaylor

@carllelandtaylor to address your couple of questions in the code:

  1. TODO before merge: does some schema need updating as well? - no, we can leave the tapirlink-related column in the db. it will not be created for new wildbooks, and should not mess up existing legacy tables
  2. MassExposeGBIF.java - i agree, this servlet should also go away, as all it does is modify tapirlink values; good call. @TanyaStere42 do you agree? i think then this would cascade to mean also altering: appadmin/admin.jsp (to remove the button) and web.xml to remove the servlet entries.

naknomum avatar Oct 15 '24 19:10 naknomum

That seems like minimal scope creep, so I'm good with it if @carllelandtaylor is

TanyaStere42 avatar Oct 15 '24 19:10 TanyaStere42

@carllelandtaylor @naknomum Can I help drive forward this removal? This is a great set of code to get rid of.

holmbergius avatar Feb 03 '25 20:02 holmbergius

@carllelandtaylor @naknomum Can I help drive forward this removal? This is a great set of code to get rid of.

Hey, sorry team that I didn't get back to this and haven't been active! Day job got extra busy.

You're welcome to take this over as far as I'm concerned!

carllelandtaylor avatar Feb 10 '25 04:02 carllelandtaylor

@carllelandtaylor @naknomum Can I help drive forward this removal? This is a great set of code to get rid of.

Hey, sorry team that I didn't get back to this and haven't been active! Day job got extra busy.

You're welcome to take this over as far as I'm concerned!

thanks for the notice and the work toward a solution.

naknomum avatar Feb 10 '25 21:02 naknomum