Wildbook icon indicating copy to clipboard operation
Wildbook copied to clipboard

[React] Hook warning fixes

Open carllelandtaylor opened this issue 1 year ago • 1 comments

Fixes various React hook warnings. Not sure if these were causing any problems yet, but some have the potential to in the future, and others are noise that could make more important warnings less visible. This also seemed like a good way to introduce myself to the React code here.

PR fixes: N/A

Changes

  1. "FrontDesk.jsx Line 25:9: The 'checkLoginStatus' function makes the dependencies of useEffect Hook (at line 59) change on every render."
  2. DataTable.jsx: Change == checks to ===

carllelandtaylor avatar Sep 02 '24 17:09 carllelandtaylor

@carllelandtaylor this has been sitting as a draft for a while now. Do you want to add any more detail to it or should I go ahead and evaluate it for inclusion in the next release?

TanyaStere42 avatar Oct 03 '24 16:10 TanyaStere42

The current FrontDesk.jsx no longer has this issue in the PR, so I will close this PR and create another one to address the === issue.

erinz2020 avatar Feb 24 '25 20:02 erinz2020