Orc.Controls icon indicating copy to clipboard operation
Orc.Controls copied to clipboard

Fix OpenFile, SaveFile, Directory pickers style

Open Dmitry-VF opened this issue 2 years ago • 6 comments

Description of Change

qQJbTqWXMx

a9OvmnIge3

ZqOboi23Dd

Fix styles to make it look more even

Issues Resolved

  • fixes #

API Changes

None

Platforms Affected

  • All
  • WPF
  • UWP
  • iOS
  • Android

Behavioral Changes

None

Testing Procedure

PR Checklist

  • [ ] I have included examples or tests
  • [ ] I have updated the change log
  • [ ] I am listed in the CONTRIBUTORS file
  • [ ] Rebased on top of the target branch at time of PR
  • [ ] Changes adhere to coding standard

Dmitry-VF avatar Apr 21 '23 19:04 Dmitry-VF

I found a problem with margins in SaveFilePicker (but i think the same problem may be in Open/Directory pickers.. need to check) If labelWidth = 0 image looks like the margins on label should be 0 when LabelWidth is 0

ceo1647 avatar Apr 22 '23 02:04 ceo1647

another one is we have to add DefaultOpenFile/Directory/SaveFilePickerStyle image and set default margins ...also i recommend set Height to {DynamicResource Size.Height}; like here: image but in a Default styles as for all other controls

ceo1647 avatar Apr 22 '23 02:04 ceo1647

image

ceo1647 avatar Apr 22 '23 02:04 ceo1647

Suggestion, maybe it's better to set default LabelWidth value to 0... as for me it's ugly solution, because you'll never get it right: image It's better to have Label separately from Picker control, then it's easier to adjust margins in a grid

ceo1647 avatar Apr 22 '23 02:04 ceo1647

Another suggestion, but for other task -> as we working on OpenFilePicker/SaveFilePicker/Directory picker ... there is a lot of extra code here because we use MVVM approach here and controls are not extendable (changed control template, styles, attached events etc); so created issue for it https://sesolutions.atlassian.net/browse/ORCOMP-657

ceo1647 avatar Apr 22 '23 02:04 ceo1647

The buttons don't seem square?

GeertvanHorrik avatar Apr 30 '23 21:04 GeertvanHorrik