Wikidata-Toolkit icon indicating copy to clipboard operation
Wikidata-Toolkit copied to clipboard

Published 20 hours ago • verified publisher icon Wikidata

Swallowed exceptions

Open robertvazan opened this issue 4 years ago • 1 comments

I notice that swallowing exceptions (catching without rethrowing or wrapping) is a widespread practice in WDTK. This can sometimes result in invalid values being propagated to application or even to API calls. Can I assume that all cases of exception swallowing are bugs and fix them?

robertvazan avatar Feb 03 '21 10:02 robertvazan

I think #526 is a clear improvement and I am sure there are tons of other places where we could do the same. Hard to say if it is true "everywhere", of course there is a judgment call to make…

wetneb avatar Feb 03 '21 11:02 wetneb