Rik Smale

@ephys since two of the failing tests are connected to DataTypes I think we should wait with making the fixes to upgrade this until after we merged #14505

I haven't really looked at the code yet, just mainly the description; - Do I understand correctly that people using MySQL have to update the names and schema of the...

Ah yes, I forgot about option 2. But that's a very valid workaround and indeed does not require further backwards compatibility

@10raw sure, go ahead! Feel free to ask questions when you have them

It seems that there was a PR that could solve this issue. I'll see if I can patch that one up and get it working with the current version next...

Hi! Thanks for the PR! I haven't given the alternative more thought yet, but can you add one or more tests for this? More tests is especially preferred if on...

@snewcomer sorry for not responding before, I took a look as well and we do not really have any tests to check our error behaviour. We'll add that in a...

> sequelize-cli uses pretty old 2.3.0 `umzug` module: > > https://github.com/sequelize/umzug/blob/v2.3.0/src/migration.js#L68 Indeed. We will update to the latest `umzug` release in v7 of the CLI.

As mentioned before, my review won't help. But it all looks good to me!

Yup, this was done in #1989