Rik Smale

Results 361 comments of Rik Smale

@ephys don't think you've seen this PR before. I think it looks good, but maybe you have some suggestions regarding the types? Or maybe suggestions for future refactoring since you...

moment-timezone is not pinned and will therefore update to the latest version when reinstalling dependencies. But it is wise that the minimum version is a safe one, so we'll update...

I would use `meta` since this should not affect other projects using sequelize

@ephys do you happen to know if eslint will fail when we try to check in CRLF lines?

Hmm, that's also not good behaviour. Maybe we can do something with our pre-commit hook that converts all CRLF to LF?

Yeah, I was thinking of allowing CRLF locally (if that's something we want in the end) and force converting to LF before committing. But I would be fine with enforcing...

I think the conclusion is that the current behaviour works fine and changing it might require more work than we really have benefits from it. @fzn0x would you agree if...

Thanks to @frostzt support for this has been added in postgres through sequelize/sequelize#15119 Support for [mssql](https://learn.microsoft.com/en-us/sql/t-sql/statements/alter-table-transact-sql?view=sql-server-2017) and [mariadb](https://mariadb.com/kb/en/alter-table/) will be added in future PRs. After those have been merged we...

@ephys I think you will be the one that can find the issue with our code the quickest. It seems that the only change from 0.13 to 0.14 is https://github.com/mmkal/expect-type/commit/8b82d3f10f0458d8cb36d02ad681a967a7d6f5cc#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80

Agree, feel free to close this in the meantime and reopen when you get to it