Rik Smale comments

Results 361 comments of


                                            Rik Smale

Stop doesn't work since update 3.0.0 and cannot find destroy also.

I believe this is related to #269

Added KBs

Closes #910 Closes #874 (in addition to the ones named before)

fix(isBIC): add `XK` to accepted BIC country codes

No, it's not part of that list. It's a special code used only for BIC (in the scope of this project)

Client side validation?

https://github.com/validatorjs/validator.js#client-side-usage https://github.com/validatorjs/validator.js/blob/86a07ba4f3f710f639e92a62cf81dd3321ef9ee8/README.md#L53-L74

improve japanese mobile phone regex

Your change should work with the current tests, right? https://github.com/validatorjs/validator.js/blob/master/test/validators.js#L8268-L8306

feat(isRgbColor): add `allowSpaces` option to allow/disallow spaces between color values

I agree that we want the default to be false, but I think we can go forward with this PR with `strict = true` and add a TODO that for...

feat(isRgbColor): add `allowSpaces` option to allow/disallow spaces between color values

Making a second PR right after this is merged to keep for the next major release would indeed be better. Good point!

IPv6 regex accepts invalid formats

Feel free to open a PR that fixes this and adds additional tests

IPv6 regex accepts invalid formats

You should push it to your own fork and then you can open a PR towards this repo

Remove 'Changes made' from README

@rubiin not sure if you've seen this one before, but might be nice to remove this line before the next release