Rik Smale

Results 361 comments of Rik Smale

It is possible that `minifyAliases` does not work properly on mssql. We run some tests for it on postgres, but not on other dialects.

You can add an integration test under this if-block; https://github.com/sequelize/sequelize/blob/5db695596dac4a2b366bb4793c3a2b7833f73e87/packages/core/test/integration/model/bulk-create.test.js#L432 Something like this should work, adapted from #11605 (does need some work on the expectations); ``` it('should inherit the ignoreDuplicates...

@divye11 are you able to resolve the merge conflicts so we can take another look at this?

I've converted it to a draft. Feel free to mark it as ready for review once you are satisfied with it and have added tests

I can't reproduce this. When I execute; `SELECT default_character_set_name FROM information_schema.SCHEMATA WHERE schema_name = "database";` I get the following result; `[ { DEFAULT_CHARACTER_SET_NAME: 'utf8mb4' } ]` You mentioned something about...

Ah, I was looking at the creation of the database but not at the actual insert. I'll do some more tests later. cesu8 from these is a converted version of...

Can you try this; ``` const sequelize = new Sequelize( config.DB_DATABASE, config.DB_USERNAME, config.DB_PASSWORD, { host: config.DB_HOST, dialect: 'mysql', logging: false, keepDefaultTimezone: true, timezone: dayjs().format('Z'), define: { timestamps: false, dialectOptions: {...

Yup, we're not setting the property correctly when we open a new connection with MySQL. I was hoping that the dialectOptions would fix it, but I need to take a...

Can you fix the prettier issue? We like to review PRs once CI has passed.

Don't worry about the failing artifact download actions, that's a known flaky thing in the new version of the action. I can just rerun the checks if needed but you...