apps-android-wikiedudashboard icon indicating copy to clipboard operation
apps-android-wikiedudashboard copied to clipboard

[BUG] Base URL is always fixed. It should change if we are logging in to wikiEducation Dashboard or outreach programs dashboard.

Open ujjwalagrawal17 opened this issue 5 years ago • 5 comments

Summary:

After Integration of Koin, the static baseUrl is changing but it seems like we are calling only outreach server APIs even if we login using wiki education dashboard.

Ideally, we should hit the APIs of the corresponding server to whom we logged in.

If we login using wiki education dashboard, all details including the courses, campaigns, stats displayed are wrong as they are of outreach dashboard server. Also, my dashboard API is failing in that case.

To fix the issue, we need to use Scope API in koin 2.0 while logging in to modify baseUrl.

Links:

  • https://github.com/InsertKoinIO/koin/issues/384
  • https://medium.com/koin-developers/ready-for-koin-2-0-2722ab59cac3

Steps to reproduce:

Login Using Wiki Education Dashboard Page.

Would you like to work on the issue? If no one picks it up, I will work on it.

ujjwalagrawal17 avatar Dec 11 '19 20:12 ujjwalagrawal17

What's the API for outreach and wiki education dashboard?

gconnect avatar Dec 12 '19 09:12 gconnect

@Darshpreet2000 @mistervaibhav , this is a high-priority bug. If anyone of you is free, feel free to try working on this.

ujjwalagrawal17 avatar Jan 15 '20 17:01 ujjwalagrawal17

I can try

Darshpreet2000 avatar Jan 15 '20 17:01 Darshpreet2000

@Darshpreet2000 @mistervaibhav , this is a high-priority bug. If anyone of you is free, feel free to try working on this.

I want to resolve this issue, I have been learning Retrofit and Koin since a few days as these topics were new to me, still I find certain things in the app pretty overwhelming and hard to grasp. @ujjwalagrawal17 can you suggest some good resources , documentations or anything which will help me . Thanks.

mistervaibhav avatar Jan 23 '20 19:01 mistervaibhav

For Koin - https://www.matrixhive.com/koin-dependency-injection/ can help. For Retrofit - https://square.github.io/retrofit/ the documentation is good.

ujjwalagrawal17 avatar Jan 24 '20 08:01 ujjwalagrawal17