WikiEduDashboard icon indicating copy to clipboard operation
WikiEduDashboard copied to clipboard

Updated course_creation_settings_form.jsx with latest react Rules

Open abhay-dev2901 opened this issue 1 year ago • 3 comments

##What this PR does This PR updates the CourseCreationSettingsForm.jsx component to comply with the latest React rules and best practices.

##The main changes include:

  1. Refactoring the component to use React hooks (useState and useEffect) for managing state and side effects.
  2. Ensuring the form state is correctly synchronized with the incoming settings prop.
  3. Adding PropTypes to enforce the expected types for the component props.

##Issue Addressed This PR addresses issue by ensuring the CourseCreationSettingsForm component is up-to-date with the latest React standards, improving maintainability and readability.

Screenshots Before: WhatsApp Image 2024-07-01 at 6 41 30 PM

After: WhatsApp Image 2024-07-01 at 6 41 58 PM

##Open questions and concerns Is there any specific validation required for the form inputs that should be added? Are there additional fields that need to be included in the form based on recent changes or requirements? Are there any performance implications of using hooks in this particular component that should be considered?

abhay-dev2901 avatar Jul 01 '24 17:07 abhay-dev2901

These screenshots are not showing the updated component. It is part of the /settings view.

ragesoss avatar Jul 01 '24 18:07 ragesoss

@ragesoss Please look at to this PR once

abhay-dev2901 avatar Jul 23 '24 07:07 abhay-dev2901

See my comment above.

ragesoss avatar Jul 23 '24 15:07 ragesoss