WikiEduDashboard icon indicating copy to clipboard operation
WikiEduDashboard copied to clipboard

Refactor: Migrate GetHelpButton from Class-Based to Functional Component

Open codic-yeeshu opened this issue 1 year ago • 3 comments

This PR refactors the GetHelpButton component from a class-based component to a functional component.

Open questions and concerns

Please let me know if there is anything missing as I am new to open source.

before changes

https://github.com/user-attachments/assets/9f1c10d4-3c50-4b51-9d19-3321539e3089

after changes

https://github.com/user-attachments/assets/2a1390a0-79c8-4753-a69e-34fc0cd592e1

codic-yeeshu avatar Jun 23 '24 15:06 codic-yeeshu

Please include before/after screenshots.

ragesoss avatar Jul 01 '24 16:07 ragesoss

@ragesoss sir, while migrating the code to functional components, I encountered a issue, there are two functions named getKey and stop which are not being used in this component so they are causing eslint error. Additionally, another error occurred due to missing I18n translations because in the original code they don't have used it. Please guide me on that.

codic-yeeshu avatar Jul 11 '24 13:07 codic-yeeshu

The eslint errors are breaking the build, and you should identify how to fix them. If the functions are not being used now, and they were before, then removing the unused functions should be part of the refactor.

The i18n warnings will not cause the build to fail, and you can ignore those.

ragesoss avatar Jul 11 '24 15:07 ragesoss