WikiEduDashboard icon indicating copy to clipboard operation
WikiEduDashboard copied to clipboard

1. Added functionality for creating new Training Libraries, adding and removing categories in these libraries

Open omChauhanDev opened this issue 1 year ago • 7 comments

What this PR does

This pr added functionality for creating new training libraries through dashboard.

Tasks :

  • [x] Implemented Validations at frontend.
  • [x] Applied access rights : Only for admin.
  • [x] Displaying success, custom error notifications to user.

Screenshots

Before:

image

After:

1. Button on main training page

image

2. Filling up form

image

3. Successfully created library

image

4. First Library

image

4. Validations at front-end

image

5. Custom Error Message

image

omChauhanDev avatar Jun 03 '24 06:06 omChauhanDev

I think having a UI similar to this(which doesn't lose all the info you entered if the library with the same name already exists) would be better.

image

TheTrio avatar Jun 05 '24 09:06 TheTrio

Yes, it would be nice to follow the same patter as the course creation modal, and to validate from the form so that errors can be fixed without starting over.

ragesoss avatar Jun 05 '24 17:06 ragesoss

okay, working on this

omChauhanDev avatar Jun 06 '24 02:06 omChauhanDev

I have updated the validation pattern, kindly check this out :

https://github.com/WikiEducationFoundation/WikiEduDashboard/assets/119471995/421aad36-6537-41e9-b553-076e857b2480

omChauhanDev avatar Jun 06 '24 05:06 omChauhanDev

I tested this out, and it's working pretty smoothly. One improvement would be to refresh the page after creating a new Library or Category, as the new one doesn't appear until after a page refresh.

ragesoss avatar Jun 18 '24 21:06 ragesoss

Hi @ragesoss and @TheTrio, I have implemented 'switching between different modes' using session storage and have also modified all the relevant test cases. I'm considering pushing this commit in a separate PR to maintain a clear separation of concerns.

For that, merging this PR will help me resolve the merge conflicts before raising the new PR.

omChauhanDev avatar Jun 20 '24 15:06 omChauhanDev

@omChauhanDev i created this branch with the earlier commits: https://github.com/WikiEducationFoundation/WikiEduDashboard/tree/Om-Training

You should open the separate PR against that branch, for dealing with merge conflicts.

ragesoss avatar Jun 20 '24 15:06 ragesoss