WikiEduDashboard icon indicating copy to clipboard operation
WikiEduDashboard copied to clipboard

The correction of how the 'error_count' is calculated in 'flags['update_logs']'.

Open Joice-crypto opened this issue 2 years ago • 4 comments

What this PR does

This PR resolves the bug from issue #5580. This PR fixes the bug; now the 'error_count' in 'flags['update_logs']' contains the total error count instead of accumulated errors.

Screenshots

Before: error_countA

After: error_countD

Joice-crypto avatar Feb 26 '24 00:02 Joice-crypto

CI is failing due to ruby linting. Please fix that running rubocop locally.

gabina avatar Feb 28 '24 14:02 gabina

CI is failing due to ruby linting. Please fix that running rubocop locally.

I fixed the files that were causing problems , but the error is still appearing in this file: spec/features/article_viewer_spec.rb:24:101: C: Layout/LineLength: Line is too long. [118/100]. But I didn't change this file and locally when I ran rubocop no errors appeared.

Joice-crypto avatar Feb 29 '24 04:02 Joice-crypto

You still have to revert some unwanted changes, such as removing a line in app/services/update_course_stats.rb. Please check all the "files changed" and revert all the changes that are not meaningful for this pull request.

gabina avatar Feb 29 '24 13:02 gabina

You still have to revert some unwanted changes, such as removing a line in app/services/update_course_stats.rb. Please check all the "files changed" and revert all the changes that are not meaningful for this pull request.

I did this. Now it's correct?

Joice-crypto avatar Mar 04 '24 20:03 Joice-crypto